mirror of
https://github.com/golang/go
synced 2024-09-30 14:18:32 -06:00
f1c4188a97
This test exposes a lot of fundamental issues with `go list` overlays. Now that we have the regression test framework, we can copy it over and make any flakes completely reproducible by waiting for each change to complete. The issue here ended up being that initial workspace load returns workspace packages with no associated files due to golang/go#39986. Working around this allows invalidation to proceed as usual. In the process of debugging this, I also noticed that packages can get loaded as command-line-arguments even when we can get the correct package path for them. It's pretty complicated to fix this, so restructured the code a tiny bit and left a TODO. I'd like to come back to this at some point, but it's not pressing since I was able to fix this bug. Fixes golang/go#39646. Updates golang/go#39986. Change-Id: Id6b08a5e92d28eddc731feb0ef3fd3b3fc69e64b Reviewed-on: https://go-review.googlesource.com/c/tools/+/240098 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> |
||
|---|---|---|
| .. | ||
| analysisinternal | ||
| apidiff | ||
| event | ||
| fakenet | ||
| fastwalk | ||
| gocommand | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| lsp | ||
| memoize | ||
| packagesinternal | ||
| proxydir | ||
| span | ||
| stack | ||
| testenv | ||
| tool | ||
| typesinternal | ||
| xcontext | ||