mirror of
https://github.com/golang/go
synced 2024-11-24 01:20:08 -07:00
68aaf2ccda
The GC program describing a data structure sometimes trusts the pointer base type and other times does not (if not, the garbage collector must fall back on per-allocation type information stored in the heap). Make the scanning of a pointer in an interface do the same. This fixes a crash in a particular use of reflect.SliceHeader. Fixes #8004. LGTM=khr R=golang-codereviews, khr CC=0xe2.0x9a.0x9b, golang-codereviews, iant, r https://golang.org/cl/100470045
60 lines
1.1 KiB
Go
60 lines
1.1 KiB
Go
// run
|
|
|
|
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"reflect"
|
|
"runtime"
|
|
"unsafe"
|
|
)
|
|
|
|
func main() {
|
|
test1()
|
|
test2()
|
|
}
|
|
|
|
func test1() {
|
|
var all []interface{}
|
|
for i := 0; i < 100; i++ {
|
|
p := new([]int)
|
|
*p = append(*p, 1, 2, 3, 4)
|
|
h := (*reflect.SliceHeader)(unsafe.Pointer(p))
|
|
all = append(all, h, p)
|
|
}
|
|
runtime.GC()
|
|
for i := 0; i < 100; i++ {
|
|
p := *all[2*i+1].(*[]int)
|
|
if p[0] != 1 || p[1] != 2 || p[2] != 3 || p[3] != 4 {
|
|
println("BUG test1: bad slice at index", i, p[0], p[1], p[2], p[3])
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
type T struct {
|
|
H *reflect.SliceHeader
|
|
P *[]int
|
|
}
|
|
|
|
func test2() {
|
|
var all []T
|
|
for i := 0; i < 100; i++ {
|
|
p := new([]int)
|
|
*p = append(*p, 1, 2, 3, 4)
|
|
h := (*reflect.SliceHeader)(unsafe.Pointer(p))
|
|
all = append(all, T{H: h}, T{P: p})
|
|
}
|
|
runtime.GC()
|
|
for i := 0; i < 100; i++ {
|
|
p := *all[2*i+1].P
|
|
if p[0] != 1 || p[1] != 2 || p[2] != 3 || p[3] != 4 {
|
|
println("BUG test2: bad slice at index", i, p[0], p[1], p[2], p[3])
|
|
return
|
|
}
|
|
}
|
|
}
|