mirror of
https://github.com/golang/go
synced 2024-11-08 19:16:25 -07:00
f22ef70254
Historically, gc optimistically parsed the left-hand side of assignments as expressions. Later, if it discovered a ":=" assignment, it rewrote the parsed expressions as declarations. This failed in the presence of dot imports though, because we lost information about whether an imported object was named via a bare identifier "Foo" or a normal qualified "pkg.Foo". This CL fixes the issue by specially noding the left-hand side of ":=" assignments. Fixes #22076. Change-Id: I18190ecdb863112e7d009e1687e6112eec559921 Reviewed-on: https://go-review.googlesource.com/66810 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Reviewed-by: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
40 lines
984 B
Go
40 lines
984 B
Go
// errorcheck
|
|
|
|
// Copyright 2011 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Issue 2231
|
|
|
|
package main
|
|
import "runtime"
|
|
|
|
func foo(runtime.UintType, i int) { // ERROR "cannot declare name runtime.UintType|mixed named and unnamed|undefined identifier"
|
|
println(i, runtime.UintType) // GCCGO_ERROR "undefined identifier"
|
|
}
|
|
|
|
func bar(i int) {
|
|
runtime.UintType := i // ERROR "non-name runtime.UintType|non-name on left side|undefined identifier"
|
|
println(runtime.UintType) // GCCGO_ERROR "invalid use of type|undefined identifier"
|
|
}
|
|
|
|
func baz() {
|
|
main.i := 1 // ERROR "non-name main.i|non-name on left side"
|
|
println(main.i) // GCCGO_ERROR "no fields or methods"
|
|
}
|
|
|
|
func qux() {
|
|
var main.i // ERROR "unexpected [.]|expected type"
|
|
println(main.i)
|
|
}
|
|
|
|
func corge() {
|
|
var foo.i int // ERROR "unexpected [.]|expected type"
|
|
println(foo.i)
|
|
}
|
|
|
|
func main() {
|
|
foo(42,43)
|
|
bar(1969)
|
|
}
|