mirror of
https://github.com/golang/go
synced 2024-11-13 20:20:30 -07:00
f0b3626904
If we've already imported a named type, then there's no need to process its associated methods except to validate that the signature matches the existing known method. However, the current import code still creates a new function node for each method, saves its inline body (if any), and adds the node to the global importlist. Because of this, the duplicate methods are never garbage collected. This CL changes the compiler to avoid amassing uncollectable garbage or performing any unnecessary processing. This is particularly noticeable for protobuf-heavy code. For the motivating Go package, this CL reduced compile max-RSS from ~12GB to ~3GB and compile time from ~65s to ~50s. Passes toolstash -cmp for std, cmd, and k8s.io/kubernetes/cmd/.... Change-Id: Ib53ba9f2ad3212995671cf6ba220ee8a56d8d009 Reviewed-on: https://go-review.googlesource.com/51331 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com> |
||
|---|---|---|
| .. | ||
| addr2line | ||
| api | ||
| asm | ||
| cgo | ||
| compile | ||
| cover | ||
| dist | ||
| doc | ||
| fix | ||
| go | ||
| gofmt | ||
| internal | ||
| link | ||
| nm | ||
| objdump | ||
| pack | ||
| pprof | ||
| trace | ||
| vendor | ||
| vet | ||