qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-30 23:08:32 -06:00
Code Releases Activity
ef1313dc6d
go/internal/lsp
History
Muir Manders ef1313dc6d internal/lsp/source: prefer unexported and non-func candidates 
A common annoying mis-completion is as follows:

    type foo struct {
      field int
    }

    func (f foo) Field() int { return f.field }

    func (f foo) logic() {
      if f.f<>
    }

Now at <> we prefer "field" over "Field()". Similarly:

    type foo struct {
    }

    func (f foo) DoSomething() { }

    func (f foo) doSomething() { }

    func (f foo) logic() {
      f.d<>
    }

Now at <> we prefer "doSomething()" over "DoSomething()". All else
being equally, you normally want private objects over public objects
when the private objects are available.

The same logic is applied to deep completions so we prefer "c.foo.bar"
over "c.Foo().bar".

Change-Id: Ic91cba7721ddb1f2a30338037693ddcce8c621f7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/223877
Run-TryBot: Muir Manders <muir@mnd.rs>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-03-23 21:07:25 +00:00
..
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/telemetry: add type safe tag keys 2020-03-18 13:29:43 +00:00
cmd internal/lsp: remove completion commands 2020-03-21 22:47:14 +00:00
debug internal/telemetry: switch metrics to use the event system 2020-03-23 14:44:30 +00:00
diff internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
fake x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/telemetry: switch metrics to use the event system 2020-03-23 14:44:30 +00:00
mod internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
protocol internal/telemetry: allow ProcessEvent to modify the event 2020-03-18 13:22:01 +00:00
regtest internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp/source: prefer unexported and non-func candidates 2020-03-23 21:07:25 +00:00
testdata internal/lsp/source: prefer unexported and non-func candidates 2020-03-23 21:07:25 +00:00
tests internal/lsp/tests: fix WorkspaceSymbols tests 2020-03-11 18:46:36 +00:00
code_action.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
command.go x/tools/gopls: run go generate through CodeLens 2020-03-17 04:34:34 +00:00
completion_test.go internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
completion.go internal/lsp: remove completion commands 2020-03-21 22:47:14 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: be more careful about showing workspace misconfig message 2020-03-23 19:22:00 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
generate.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
highlight.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
lsp_test.go internal/lsp: support when hierarchicalDocumentSymbolSupport is false 2020-03-06 18:17:37 +00:00
references.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
signature_help.go internal/telemetry: delete the event.TagOf method 2020-03-18 13:23:15 +00:00
symbols.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
text_synchronization.go internal/lsp: clear diagnostics for deleted files 2020-02-19 20:26:41 +00:00
workspace_symbol.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00