Heschi Kreinick ecd3fc4348 internal/lsp: read files eagerly ... We use file identities pervasively throughout gopls. Prior to this change, the identity is the modification date of an unopened file, or the hash of an opened file. That means that opening a file changes its identity, which causes unnecessary churn in the cache. Unfortunately, there isn't an easy way to fix this. Changing the cache key to something else, such as the modification time, means that we won't unify cache entries if a change is made and then undone. The approach here is to read files eagerly in GetFile, so that we know their hashes immediately. That resolves the churn, but means that we do a ton of file IO at startup. Incidental changes: Remove the FileSystem interface; there was only one implementation and it added a fair amount of cruft. We have many other places that assume os.Stat and such work. Add direct accessors to FileHandle for URI, Kind, and Version. Most uses of (FileHandle).Identity were for stuff that we derive solely from the URI, and this helped me disentangle them. It is a *ton* of churn, though. I can revert it if you want. Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-06-11 22:11:59 +00:00
..
code_lens.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_format.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer smart "append()" completions	2020-05-20 22:05:37 +00:00
completion.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
fill_struct.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
folding_range.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
format_test.go	internal/lsp: fix new bug duplicating comments after includes	2020-05-19 20:57:26 +00:00
format.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
highlight.go	internal/lsp/source: support labeled statements when highlighting loops	2020-06-10 05:20:24 +00:00
hover.go	internal/lsp: fix docs on hover for var/const blocks	2020-05-18 19:53:06 +00:00
identifier.go	internal/lsp/source: handle nil pointer in package name hover	2020-05-11 19:44:01 +00:00
implementation.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
options.go	internal/lsp: support go mod vendor as a command	2020-06-04 18:33:45 +00:00
references.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
rename_check.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
rename.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
signature_help.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
source_test.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
symbols.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
types_format.go	internal/lsp: return in the default case in cloneExpr	2020-05-09 03:07:07 +00:00
util.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
view.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
workspace_symbol.go	internal/lsp: add config option for SymbolMatch	2020-05-11 19:58:58 +00:00