mirror of
https://github.com/golang/go
synced 2024-11-06 20:26:14 -07:00
f451a318bb
Remove unnecessary race.Release annotation from Unlock. For RWMutex we want to establish the following happens-before (HB) edges: 1. Between Unlock and the subsequent Lock. 2. Between Unlock and the subsequent RLock. 3. Between batch of RUnlock's and the subsequent Lock. 1 is provided by Release(&rw.readerSem) in Unlock and Acquire(&rw.readerSem) in Lock. 2 is provided by Release(&rw.readerSem) in Unlock and Acquire(&rw.readerSem) in RLock. 3 is provided by ReleaseMerge(&rw.writerSem) in RUnlock in Acquire(&rw.writerSem) in Lock, since we want to establish HB between a batch of RUnlock's this uses ReleaseMerge instead of Release. Release(&rw.writerSem) in Unlock is simply not needed. FWIW this is also how C++ tsan handles mutexes, not a proof but at least something. Making 2 implementations consistent also simplifies any kind of reasoning against both of them. Since this only affects performance, a reasonable test is not possible. Everything should just continue to work but slightly faster. Credit for discovering this goes to Jamie Liu. Change-Id: Ice37d29ecb7a5faed3f7781c38dd32c7469b2735 Reviewed-on: https://go-review.googlesource.com/120495 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
147 lines
4.3 KiB
Go
147 lines
4.3 KiB
Go
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package sync
|
|
|
|
import (
|
|
"internal/race"
|
|
"sync/atomic"
|
|
"unsafe"
|
|
)
|
|
|
|
// There is a modified copy of this file in runtime/rwmutex.go.
|
|
// If you make any changes here, see if you should make them there.
|
|
|
|
// A RWMutex is a reader/writer mutual exclusion lock.
|
|
// The lock can be held by an arbitrary number of readers or a single writer.
|
|
// The zero value for a RWMutex is an unlocked mutex.
|
|
//
|
|
// A RWMutex must not be copied after first use.
|
|
//
|
|
// If a goroutine holds a RWMutex for reading and another goroutine might
|
|
// call Lock, no goroutine should expect to be able to acquire a read lock
|
|
// until the initial read lock is released. In particular, this prohibits
|
|
// recursive read locking. This is to ensure that the lock eventually becomes
|
|
// available; a blocked Lock call excludes new readers from acquiring the
|
|
// lock.
|
|
type RWMutex struct {
|
|
w Mutex // held if there are pending writers
|
|
writerSem uint32 // semaphore for writers to wait for completing readers
|
|
readerSem uint32 // semaphore for readers to wait for completing writers
|
|
readerCount int32 // number of pending readers
|
|
readerWait int32 // number of departing readers
|
|
}
|
|
|
|
const rwmutexMaxReaders = 1 << 30
|
|
|
|
// RLock locks rw for reading.
|
|
//
|
|
// It should not be used for recursive read locking; a blocked Lock
|
|
// call excludes new readers from acquiring the lock. See the
|
|
// documentation on the RWMutex type.
|
|
func (rw *RWMutex) RLock() {
|
|
if race.Enabled {
|
|
_ = rw.w.state
|
|
race.Disable()
|
|
}
|
|
if atomic.AddInt32(&rw.readerCount, 1) < 0 {
|
|
// A writer is pending, wait for it.
|
|
runtime_SemacquireMutex(&rw.readerSem, false)
|
|
}
|
|
if race.Enabled {
|
|
race.Enable()
|
|
race.Acquire(unsafe.Pointer(&rw.readerSem))
|
|
}
|
|
}
|
|
|
|
// RUnlock undoes a single RLock call;
|
|
// it does not affect other simultaneous readers.
|
|
// It is a run-time error if rw is not locked for reading
|
|
// on entry to RUnlock.
|
|
func (rw *RWMutex) RUnlock() {
|
|
if race.Enabled {
|
|
_ = rw.w.state
|
|
race.ReleaseMerge(unsafe.Pointer(&rw.writerSem))
|
|
race.Disable()
|
|
}
|
|
if r := atomic.AddInt32(&rw.readerCount, -1); r < 0 {
|
|
if r+1 == 0 || r+1 == -rwmutexMaxReaders {
|
|
race.Enable()
|
|
throw("sync: RUnlock of unlocked RWMutex")
|
|
}
|
|
// A writer is pending.
|
|
if atomic.AddInt32(&rw.readerWait, -1) == 0 {
|
|
// The last reader unblocks the writer.
|
|
runtime_Semrelease(&rw.writerSem, false)
|
|
}
|
|
}
|
|
if race.Enabled {
|
|
race.Enable()
|
|
}
|
|
}
|
|
|
|
// Lock locks rw for writing.
|
|
// If the lock is already locked for reading or writing,
|
|
// Lock blocks until the lock is available.
|
|
func (rw *RWMutex) Lock() {
|
|
if race.Enabled {
|
|
_ = rw.w.state
|
|
race.Disable()
|
|
}
|
|
// First, resolve competition with other writers.
|
|
rw.w.Lock()
|
|
// Announce to readers there is a pending writer.
|
|
r := atomic.AddInt32(&rw.readerCount, -rwmutexMaxReaders) + rwmutexMaxReaders
|
|
// Wait for active readers.
|
|
if r != 0 && atomic.AddInt32(&rw.readerWait, r) != 0 {
|
|
runtime_SemacquireMutex(&rw.writerSem, false)
|
|
}
|
|
if race.Enabled {
|
|
race.Enable()
|
|
race.Acquire(unsafe.Pointer(&rw.readerSem))
|
|
race.Acquire(unsafe.Pointer(&rw.writerSem))
|
|
}
|
|
}
|
|
|
|
// Unlock unlocks rw for writing. It is a run-time error if rw is
|
|
// not locked for writing on entry to Unlock.
|
|
//
|
|
// As with Mutexes, a locked RWMutex is not associated with a particular
|
|
// goroutine. One goroutine may RLock (Lock) a RWMutex and then
|
|
// arrange for another goroutine to RUnlock (Unlock) it.
|
|
func (rw *RWMutex) Unlock() {
|
|
if race.Enabled {
|
|
_ = rw.w.state
|
|
race.Release(unsafe.Pointer(&rw.readerSem))
|
|
race.Disable()
|
|
}
|
|
|
|
// Announce to readers there is no active writer.
|
|
r := atomic.AddInt32(&rw.readerCount, rwmutexMaxReaders)
|
|
if r >= rwmutexMaxReaders {
|
|
race.Enable()
|
|
throw("sync: Unlock of unlocked RWMutex")
|
|
}
|
|
// Unblock blocked readers, if any.
|
|
for i := 0; i < int(r); i++ {
|
|
runtime_Semrelease(&rw.readerSem, false)
|
|
}
|
|
// Allow other writers to proceed.
|
|
rw.w.Unlock()
|
|
if race.Enabled {
|
|
race.Enable()
|
|
}
|
|
}
|
|
|
|
// RLocker returns a Locker interface that implements
|
|
// the Lock and Unlock methods by calling rw.RLock and rw.RUnlock.
|
|
func (rw *RWMutex) RLocker() Locker {
|
|
return (*rlocker)(rw)
|
|
}
|
|
|
|
type rlocker RWMutex
|
|
|
|
func (r *rlocker) Lock() { (*RWMutex)(r).RLock() }
|
|
func (r *rlocker) Unlock() { (*RWMutex)(r).RUnlock() }
|