ec0b540293
Parts of package pgo fetch the line number of a node by parsing the number out of the string returned from ir.Line(). This is indirect and inefficient, so it should be replaced with a more direct lookup. It is also potentially buggy: ir.Line uses ctxt.OutermostPos, i.e., the line number where an inlined node in inlined. We want ctxt.InnermostPos, because that is the line number used in pprof profiles that we are matching against (See comments on OutermostPos and InnermostPos). I'm not sure whether this was an active, as we use ir.Line before and during inlining. I think we could see CALL nodes with OutermostPos != InnermostPos during midstack inlining, but I am not sure. Regardless, explicitly using the desired position is clearer. For #55022. Change-Id: Ic640761c9e1d01cacbf91f3aaeaf284ad7e38dbd Reviewed-on: https://go-review.googlesource.com/c/go/+/446302 Reviewed-by: Cherry Mui <cherryyz@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Pratt <mpratt@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.