1
0
mirror of https://github.com/golang/go synced 2024-09-25 11:10:13 -06:00
The Go programming language
Go to file
Russ Cox eb592d8289 cmd/gc: do not follow uintptr passed as function argument
The escape analysis works by tracing assignment paths from
variables that start with pointer type, or addresses of variables
(addresses are always pointers).  It does allow non-pointers
in the path, so that in this code it sees x's value escape into y:

        var x *[10]int
        y := (*int)(unsafe.Pointer(uintptr(unsafe.Pointer(x))+32))

It must allow uintptr in order to see through this kind of
"pointer arithmetic".

It also traces such values if they end up as uintptrs passed to
functions. This used to be important because packages like
encoding/gob passed around uintptrs holding real pointers.

The introduction of precise collection of stacks has forced
code to be more honest about which declared stack variables
hold pointers and which do not. In particular, the garbage
collector no longer sees pointers stored in uintptr variables.
Because of this, packages like encoding/gob have been fixed.

There is not much point in the escape analysis accepting
uintptrs as holding pointers at call boundaries if the garbage
collector does not.

Excluding uintptr-valued arguments brings the escape
analysis in line with the garbage collector and has the
useful side effect of making arguments to syscall.Syscall
not appear to escape.

That is, this CL should yield the same benefits as
CL 45930043 (rolled back in CL 53870043), but it does
so by making uintptrs less special, not more.

R=golang-codereviews, iant
CC=golang-codereviews
https://golang.org/cl/53940043
2014-01-21 13:31:34 -05:00
api api: update next.txt 2014-01-14 10:18:43 -08:00
doc doc: replace "private" with "unexported" in Effective Go. 2014-01-17 09:06:39 -08:00
include liblink: check for symgrow size too large 2014-01-21 06:12:54 -08:00
lib codereview: switch defaultcc to golang-codereviews 2013-12-20 10:53:50 -05:00
misc runtime: co-exist with NPTL's pthread_cancel. 2014-01-09 09:34:04 -08:00
src cmd/gc: do not follow uintptr passed as function argument 2014-01-21 13:31:34 -05:00
test cmd/gc: handle non-escaping address-taken variables better 2014-01-16 10:32:30 -05:00
.hgignore .hgignore: remove duplicate entry 2013-12-12 19:01:50 -08:00
.hgtags tag go1.2 2013-12-02 09:06:41 +11:00
AUTHORS A+C: Maxim Khitrov (individual CLA) 2014-01-17 11:26:42 -05:00
CONTRIBUTORS A+C: Maxim Khitrov (individual CLA) 2014-01-17 11:26:42 -05:00
favicon.ico godoc: update favicon 2012-10-11 17:02:36 +11:00
LICENSE doc: update licensing text one more time 2012-03-27 15:09:13 +11:00
PATENTS LICENSE: separate, change PATENTS text 2010-12-06 16:31:59 -05:00
README README: Fix installation instructions 2013-11-20 13:47:37 -08:00
robots.txt godoc: serve robots.txt raw 2011-02-19 05:46:20 +11:00

This is the source code repository for the Go programming language.  

For documentation about how to install and use Go,
visit http://golang.org/ or load doc/install-source.html
in your web browser.

After installing Go, you can view a nicely formatted
doc/install-source.html by running godoc --http=:6060
and then visiting http://localhost:6060/doc/install/source.

Unless otherwise noted, the Go source files are distributed
under the BSD-style license found in the LICENSE file.

--

Binary Distribution Notes

If you have just untarred a binary Go distribution, you need to set
the environment variable $GOROOT to the full path of the go
directory (the one containing this README).  You can omit the
variable if you unpack it into /usr/local/go, or if you rebuild
from sources by running all.bash (see doc/install.html).
You should also add the Go binary directory $GOROOT/bin
to your shell's path.

For example, if you extracted the tar file into $HOME/go, you might
put the following in your .profile:

    export GOROOT=$HOME/go
    export PATH=$PATH:$GOROOT/bin

See doc/install.html for more details.