1
0
mirror of https://github.com/golang/go synced 2024-11-27 03:31:29 -07:00
go/src
Filippo Valsorda eb30ac3472 crypto/rsa: use E = 65537 in benchmarks
Now, this is embarrassing. For the whole Go 1.20 and Go 1.21 cycles, we
based RSA public key operation (verification and decryption) benchmarks
on the keys in rsa_test.go, which had E = 3. Most keys in use, including
all those generated by GenerateKey, have E = 65537. This significantly
skewed even relative benchmarks, because the new constant-time
algorithms would incur a larger slowdown for larger exponents.

I noticed this only because I got a production profile for an
application that does a lot of RSA verifications, saw ExpShort show up,
made ExpShort faster, and the crypto/rsa profiles didn't move.

We were measuring the wrong thing, and the slowdown was worse than we
thought. My apologies.

(If E had not been parametrized, it would have avoided issues like this
one, too. Grumble. https://words.filippo.io/parameters/#fn9)

goos: darwin
goarch: arm64
pkg: crypto/rsa
                       │ g35222eeb78 │                 new                 │
                       │   sec/op    │   sec/op     vs base                │
DecryptPKCS1v15/2048-8   1.414m ± 2%   1.417m ± 1%        ~ (p=0.971 n=10)
DecryptPKCS1v15/3072-8   4.107m ± 0%   4.160m ± 1%   +1.29% (p=0.000 n=10)
DecryptPKCS1v15/4096-8   9.363m ± 1%   9.305m ± 1%        ~ (p=0.143 n=10)
EncryptPKCS1v15/2048-8   162.8µ ± 2%   212.1µ ± 0%  +30.34% (p=0.000 n=10)
DecryptOAEP/2048-8       1.460m ± 4%   1.413m ± 1%        ~ (p=0.105 n=10)
EncryptOAEP/2048-8       161.7µ ± 0%   213.4µ ± 0%  +31.99% (p=0.000 n=10)
SignPKCS1v15/2048-8      1.419m ± 1%   1.476m ± 1%   +4.05% (p=0.000 n=10)
VerifyPKCS1v15/2048-8    160.6µ ± 0%   212.6µ ± 3%  +32.38% (p=0.000 n=10)
SignPSS/2048-8           1.419m ± 0%   1.477m ± 2%   +4.07% (p=0.000 n=10)
VerifyPSS/2048-8         163.9µ ± 8%   212.3µ ± 0%  +29.50% (p=0.000 n=10)
geomean                  802.5µ        899.1µ       +12.04%

Updates #63516

Change-Id: Iab4a0684d8101ae07dac8462908d8058fe5e9f3d
Reviewed-on: https://go-review.googlesource.com/c/go/+/552895
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
2024-01-12 00:55:41 +00:00
..
archive
arena
bufio
builtin builtin: mention PanicNilError in comments of recover 2023-12-18 19:42:41 +00:00
bytes bytes: add a boundary test for Count of 1 byte 2023-11-30 20:05:58 +00:00
cmd go/types, types2: don't lose position info of interface embeddings 2024-01-11 17:47:50 +00:00
cmp
compress
container
context
crypto crypto/rsa: use E = 65537 in benchmarks 2024-01-12 00:55:41 +00:00
database/sql all: remove newline characters after return statements 2023-12-14 17:22:18 +00:00
debug all: replace outdated links 2023-12-30 00:24:56 +00:00
embed
encoding
errors errors: clarify references to Unwrap in doc 2023-11-21 22:04:29 +00:00
expvar
flag
fmt
go go/types, types2: don't lose position info of interface embeddings 2024-01-11 17:47:50 +00:00
hash all: remove newline characters after return statements 2023-12-14 17:22:18 +00:00
html
image
index/suffixarray
internal runtime: ensure we free unrolled GC bitmaps 2024-01-11 21:16:56 +00:00
io io/fs,path/filepath: fix typo in SkipAll/SkipDir doc 2024-01-09 08:50:19 +00:00
iter iter: fix race instrumentation for Pull2 2023-12-13 16:20:09 +00:00
log log/slog: clarify SetDefault behavior 2024-01-08 18:26:18 +00:00
maps maps: fix aliasing problems with Clone 2023-12-05 17:05:56 +00:00
math math/big: fix uint64 overflow in nat.mulRange 2024-01-09 15:29:36 +00:00
mime
net net: add available godoc link 2024-01-10 03:29:50 +00:00
os os: relax tests and add examples for UserCacheDir and UserConfigDir 2024-01-10 17:35:49 +00:00
path io/fs,path/filepath: fix typo in SkipAll/SkipDir doc 2024-01-09 08:50:19 +00:00
plugin
reflect reflect: fix typo in type.go 2023-12-30 00:23:59 +00:00
regexp
runtime runtime: ensure we free unrolled GC bitmaps 2024-01-11 21:16:56 +00:00
slices slices: explicitly discard results of some functions 2024-01-05 21:35:07 +00:00
sort sort: add available godoc link 2023-11-28 16:40:32 +00:00
strconv
strings
sync sync: use map[any]any instead of map[interface{}]interface{} in the godoc 2024-01-08 17:02:01 +00:00
syscall syscall: remove ptrace1 on darwin 2023-11-27 21:34:30 +00:00
testdata
testing testing: add regression tests for reentrant calls to T.Run 2023-12-01 21:27:08 +00:00
text all: remove newline characters after return statements 2023-12-14 17:22:18 +00:00
time
unicode
unsafe
vendor all: update vendored dependencies 2023-11-29 21:28:33 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies 2023-11-29 21:28:33 +00:00
go.sum all: update vendored dependencies 2023-11-29 21:28:33 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.