eabf3bf688
Currently, Builder.fmtcmd can read scriptDir without taking the output lock. This introduces a potential data race between the read in fmtcmd and the write in Showcmd. There's also a logical race here: because fmtcmd doesn't know when its output is going to be printed, Showcmd may print a "cd" command between when fmtcmd is called and when its output is printed. As a result, it doesn't make sense to just lock around the access in fmtcmd. Instead, move the entire scriptDir substitution to Showcmd. This will generally result in the same output. In the cases where Builder.run is called with a non-empty desc, it means we may print a full path in the comment line above output rather than substituting the script directory. I think this is okay. This lets us undo the workaround in CL 536355. Change-Id: I617fe136eaafcc9bbb7e701b427d956aeab8a2b2 Reviewed-on: https://go-review.googlesource.com/c/go/+/536376 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Bryan Mills <bcmills@google.com> Auto-Submit: Austin Clements <austin@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.