1
0
mirror of https://github.com/golang/go synced 2024-11-26 20:21:25 -07:00
go/src
Adam Langley ea64e5785d crypto/tls: fix renegotiation extension.
There are two methods by which TLS clients signal the renegotiation
extension: either a special cipher suite value or a TLS extension.

It appears that I left debugging code in when I landed support for the
extension because there's a "+ 1" in the switch statement that shouldn't
be there.

The effect of this is very small, but it will break Firefox if
security.ssl.require_safe_negotiation is enabled in about:config.
(Although almost nobody does this.)

This change fixes the original bug and adds a test. Sadly the test is a
little complex because there's no OpenSSL s_client option that mirrors
that behaviour of require_safe_negotiation.

Change-Id: Ia6925c7d9bbc0713e7104228a57d2d61d537c07a
Reviewed-on: https://go-review.googlesource.com/1900
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2015-01-06 19:50:07 +00:00
..
archive archive/tar: document Reader.Next's behavior at the end 2014-12-30 21:38:37 +00:00
bufio
builtin
bytes
cmd cmd/gc: add write barrier for append(slice, slice...) 2015-01-06 14:41:45 +00:00
compress
container
crypto crypto/tls: fix renegotiation extension. 2015-01-06 19:50:07 +00:00
database/sql
debug
encoding encoding/gob: address go vet report 2014-12-28 19:30:31 +00:00
errors
expvar
flag
fmt fmt: fix two typos 2015-01-04 23:07:43 +00:00
go go/doc: propagate types from unexported constants 2015-01-06 00:24:13 +00:00
hash
html
image image: use three-index slice for NewYCbCr. 2015-01-05 03:32:15 +00:00
index/suffixarray
internal/syscall
io
lib9
libbio
liblink Revert "liblink, cmd/ld, runtime: remove stackguard1" 2015-01-05 16:29:56 +00:00
log log: update doc comment 2015-01-05 01:21:52 +00:00
math math/big: panic if n <= 0 for ProbablyPrime 2015-01-05 23:11:35 +00:00
mime
net net: add test cases for parsing ipv4-mapped ipv6 address 2015-01-04 10:28:00 +00:00
os os: replace itod on posix with general itoa and fix possible infinite recursion 2015-01-02 16:21:18 +00:00
path
reflect reflect: add write barriers 2015-01-06 00:28:31 +00:00
regexp
runtime runtime: fix two garbage collector bugs 2015-01-06 15:10:13 +00:00
sort
strconv strconv: optimize decimal to string conversion 2014-12-30 23:28:02 +00:00
strings
sync sync/atomic: remove atomic pointer hammer tests 2015-01-06 00:28:22 +00:00
syscall
testing testing/iotest: fix copy/paste error in comment 2014-12-29 19:05:37 +00:00
text
time
unicode
unsafe
all.bash
all.bat
all.rc
androidtest.bash
clean.bash
clean.bat
clean.rc
make.bash
make.bat
Make.dist
make.rc
nacltest.bash
race.bash
race.bat
run.bash
run.bat
run.rc
sudo.bash