1
0
mirror of https://github.com/golang/go synced 2024-11-19 00:54:42 -07:00
go/internal
Suzy Mueller ea4142463b internal/imports: merge import declarations
When an import is added to the ast, the import declarations are merged
together into the first import declaration. Since this is a part of
the formatting functionality of goimports, do this during formatting
regardless.

The merging pass was added to astutil.AddNamedImport in order to address
issue golang/go#14075. This joined imports from other blocks into the first
import declaration, so that a single block of imports isn't split across
multiple blocks.

This functionality is more of a formatting change than a fix imports
change, in line with sorting the imports, which occurs even when
FormatOnly. The formatting was only applied when an import was added
(not renamed or deleted). This change makes formatting by goimports
more consistent across runs and is not dependent on the exact fixes
that need to be applied.

Change-Id: Icb90bf694ff35e2d6405a3d477cf82fcd3e697e0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/189941
Run-TryBot: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-08-14 23:54:02 +00:00
..
apidiff apidiff: represent a Report as a list of Changes 2019-04-22 23:39:26 +00:00
fastwalk internal/fastwalk: avoid slice bounds out of range for long file names 2018-11-12 23:16:31 +00:00
gopathwalk internal/gopathwalk: fix typo ("nonexistant" → "nonexistent") 2019-08-02 00:38:18 +00:00
imports internal/imports: merge import declarations 2019-08-14 23:54:02 +00:00
jsonrpc2 internal/lsp: use a background context for the background worker 2019-07-18 19:01:55 +00:00
lsp internal/lsp: fix race condition in caching 2019-08-14 16:34:44 +00:00
memoize internal/lsp: stop making background contexts everywhere 2019-07-11 16:38:52 +00:00
module imports: stop using go/packages for modules 2019-01-22 20:29:12 +00:00
semver go/packages: add name= query 2018-10-16 20:20:09 +00:00
span internal/span: handle character values beyond end of line in FromUTF16Column 2019-07-06 07:08:13 +00:00
tool internal/tool: add a small package to unify the flag handling across all our tools 2018-12-17 23:08:00 +00:00
txtar imports: stop using go/packages for modules 2019-01-22 20:29:12 +00:00
xcontext internal/lsp: stop making background contexts everywhere 2019-07-11 16:38:52 +00:00