1
0
mirror of https://github.com/golang/go synced 2024-11-15 01:40:25 -07:00
go/src
Cuong Manh Le ea38fa5345 cmd/compile: fix mis-compilation with labeled fallthrough
A fallthrough statement can be a labeled fallthrough per Go spec.
However, the hasFallthrough function is not considering this case,
causing mis-compilation.

Fixing this by un-wrapping (possible nested) labeled fallthrough
statements if any.

Fixes #70173

Change-Id: Ic93d4fb75ff02703a32dfc63c3e84a8b7f78c261
Reviewed-on: https://go-review.googlesource.com/c/go/+/624717
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Youlin Feng <fengyoulin@live.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-11-04 16:54:28 +00:00
..
archive
arena
bufio bufio: add example for ReadFrom and remove unused code 2024-11-01 21:52:12 +00:00
builtin
bytes strings,bytes: use result of copy in subsequent slicing 2024-10-29 16:47:05 +00:00
cmd cmd/compile: fix mis-compilation with labeled fallthrough 2024-11-04 16:54:28 +00:00
cmp
compress
container
context
crypto crypto/rand: skip TestAllocations on plan9 2024-10-31 21:41:16 +00:00
database/sql database/sql: allocate once when assigning a time.Time to a byte slice 2024-10-29 11:38:05 +00:00
debug
embed
encoding all: skip and fix various tests with -asan and -msan 2024-10-28 21:04:51 +00:00
errors
expvar
flag
fmt
go go/types, types2: print variadic argument in dotdotdot form in error message 2024-11-04 16:26:42 +00:00
hash hash/maphash: sync wyhash with runtime implementation 2024-10-23 16:06:43 +00:00
html
image image/jpeg: add more theHuffmanSpec comments 2024-11-03 17:18:11 +00:00
index/suffixarray
internal go/types, types2: print variadic argument in dotdotdot form in error message 2024-11-04 16:26:42 +00:00
io
iter
log all: skip and fix various tests with -asan and -msan 2024-10-28 21:04:51 +00:00
maps
math math/big: properly linkify a reference 2024-10-31 19:23:59 +00:00
mime
net net,os: consolidate poll.SendFile sending until EOF with 0 2024-11-01 01:09:12 +00:00
os net,os: consolidate poll.SendFile sending until EOF with 0 2024-11-01 01:09:12 +00:00
path
plugin
reflect runtime,internal/runtime/maps: specialized swissmaps 2024-10-30 15:14:31 +00:00
regexp
runtime runtime: fix out-of-date comment doc 2024-11-01 22:46:06 +00:00
slices slice, sort: correct triple of xorshift RNG 2024-11-02 07:24:25 +00:00
sort slice, sort: correct triple of xorshift RNG 2024-11-02 07:24:25 +00:00
strconv
strings all: skip and fix various tests with -asan and -msan 2024-10-28 21:04:51 +00:00
structs
sync
syscall syscall: only remove write data access when O_APPEND is set on Windows 2024-10-23 17:23:13 +00:00
testdata
testing
text
time
unicode
unique
unsafe
vendor all: update golang.org/x/text to v0.19.0 2024-11-01 21:50:47 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update golang.org/x/text to v0.19.0 2024-11-01 21:50:47 +00:00
go.sum all: update golang.org/x/text to v0.19.0 2024-11-01 21:50:47 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Also, ensure that 'go env GOROOT' shows the root of this Go source
tree. Otherwise, the results are undefined. It's recommended to build
Go from source and use that 'go' binary to update its source tree.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.