1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:54:42 -07:00
go/internal/lsp/regtest
Heschi Kreinick e9a00ec821 internal/lsp/cache: correctly split env vars
We were using strings.Split on env vars, which did bad stuff when the
var contained an =, e.g. GOFLAGS=-tags=foo. Only split on the first =.

Irritatingly, this breaks only `go mod` commands, so almost nothing in
gopls failed, just organize imports and the `go.mod` code lens stuff.

Fixes golang/go#38669

Change-Id: I8d28c806b77a8df92100af1fa4fbcca5edf97cff
Reviewed-on: https://go-review.googlesource.com/c/tools/+/230560
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-04-28 18:55:08 +00:00
..
definition_test.go internal/lsp/regtest: put testing.T back in the test func signature 2020-04-14 18:42:46 +00:00
diagnostics_114_test.go internal/lsp/regtest: add regtest for golang/go#38207 2020-04-22 01:51:11 +00:00
diagnostics_test.go internal/lsp/cache: correctly split env vars 2020-04-28 18:55:08 +00:00
env_test.go internal/lsp/regtest: track outstanding work using the progress API 2020-04-23 20:44:50 +00:00
env.go internal/lsp/regtest: track outstanding work using the progress API 2020-04-23 20:44:50 +00:00
formatting_test.go internal/lsp/regtest: put testing.T back in the test func signature 2020-04-14 18:42:46 +00:00
reg_test.go internal/lsp/regtest: generalize expectations beyond diagnostic messages 2020-04-16 21:39:01 +00:00
serialization_test.go internal/lsp/regtest: put testing.T back in the test func signature 2020-04-14 18:42:46 +00:00
shared_test.go internal/lsp/regtest: add support for custom test proxy data 2020-04-16 19:38:27 +00:00
wrappers.go internal/lsp: add regtest for golang/go#38211 2020-04-22 01:32:14 +00:00