mirror of
https://github.com/golang/go
synced 2024-11-19 00:54:42 -07:00
e931b35e96
This change stops the memory leak from happening. It does not stop the large number of allocations done by analysis, however, so these still need to be prevented through correct cancellation. Change-Id: I1cf7fbf6f85ed413af1f2ea55f91862a6d7f2db7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204558 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
362 lines
11 KiB
Go
362 lines
11 KiB
Go
package cache
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"go/token"
|
|
"go/types"
|
|
"reflect"
|
|
"sort"
|
|
"sync"
|
|
|
|
"golang.org/x/sync/errgroup"
|
|
"golang.org/x/tools/go/analysis"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
"golang.org/x/tools/internal/memoize"
|
|
"golang.org/x/tools/internal/telemetry/log"
|
|
errors "golang.org/x/xerrors"
|
|
)
|
|
|
|
func (s *snapshot) Analyze(ctx context.Context, id string, analyzers []*analysis.Analyzer) ([]*source.Error, error) {
|
|
var roots []*actionHandle
|
|
|
|
for _, a := range analyzers {
|
|
ah, err := s.actionHandle(ctx, packageID(id), source.ParseFull, a)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
roots = append(roots, ah)
|
|
}
|
|
|
|
// Check if the context has been canceled before running the analyses.
|
|
if ctx.Err() != nil {
|
|
return nil, ctx.Err()
|
|
}
|
|
|
|
var results []*source.Error
|
|
for _, ah := range roots {
|
|
diagnostics, _, err := ah.analyze(ctx)
|
|
if err != nil {
|
|
log.Error(ctx, "no results", err)
|
|
continue
|
|
}
|
|
results = append(results, diagnostics...)
|
|
}
|
|
return results, nil
|
|
}
|
|
|
|
// An action represents one unit of analysis work: the application of
|
|
// one analysis to one package. Actions form a DAG, both within a
|
|
// package (as different analyzers are applied, either in sequence or
|
|
// parallel), and across packages (as dependencies are analyzed).
|
|
type actionHandle struct {
|
|
handle *memoize.Handle
|
|
|
|
analyzer *analysis.Analyzer
|
|
pkg *pkg
|
|
}
|
|
|
|
type actionData struct {
|
|
diagnostics []*source.Error
|
|
result interface{}
|
|
objectFacts map[objectFactKey]analysis.Fact
|
|
packageFacts map[packageFactKey]analysis.Fact
|
|
err error
|
|
}
|
|
|
|
type objectFactKey struct {
|
|
obj types.Object
|
|
typ reflect.Type
|
|
}
|
|
|
|
type packageFactKey struct {
|
|
pkg *types.Package
|
|
typ reflect.Type
|
|
}
|
|
|
|
func (s *snapshot) actionHandle(ctx context.Context, id packageID, mode source.ParseMode, a *analysis.Analyzer) (*actionHandle, error) {
|
|
ah := s.getAction(id, mode, a)
|
|
if ah != nil {
|
|
return ah, nil
|
|
}
|
|
cph := s.getPackage(id, mode)
|
|
if cph == nil {
|
|
return nil, errors.Errorf("no CheckPackageHandle for %s:%v", id, mode == source.ParseExported)
|
|
}
|
|
if len(cph.key) == 0 {
|
|
return nil, errors.Errorf("no key for CheckPackageHandle %s", id)
|
|
}
|
|
pkg, err := cph.check(ctx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
ah = &actionHandle{
|
|
analyzer: a,
|
|
pkg: pkg,
|
|
}
|
|
var deps []*actionHandle
|
|
// Add a dependency on each required analyzers.
|
|
for _, req := range a.Requires {
|
|
reqActionHandle, err := s.actionHandle(ctx, id, mode, req)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
deps = append(deps, reqActionHandle)
|
|
}
|
|
// An analysis that consumes/produces facts
|
|
// must run on the package's dependencies too.
|
|
if len(a.FactTypes) > 0 {
|
|
importIDs := make([]string, 0, len(cph.m.deps))
|
|
for _, importID := range cph.m.deps {
|
|
importIDs = append(importIDs, string(importID))
|
|
}
|
|
sort.Strings(importIDs) // for determinism
|
|
for _, importID := range importIDs {
|
|
depActionHandle, err := s.actionHandle(ctx, packageID(importID), source.ParseExported, a)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
deps = append(deps, depActionHandle)
|
|
}
|
|
}
|
|
|
|
fset := s.view.session.cache.fset
|
|
|
|
h := s.view.session.cache.store.Bind(buildActionKey(a, cph), func(ctx context.Context) interface{} {
|
|
data := &actionData{}
|
|
// Analyze dependencies.
|
|
results, err := execAll(ctx, fset, deps)
|
|
if err != nil {
|
|
data.err = err
|
|
return nil
|
|
}
|
|
data.diagnostics, data.result, data.objectFacts, data.packageFacts, data.err = runAnalysis(ctx, fset, a, pkg, results)
|
|
return data
|
|
})
|
|
ah.handle = h
|
|
|
|
s.addAction(ah)
|
|
return ah, nil
|
|
}
|
|
|
|
func (act *actionHandle) analyze(ctx context.Context) ([]*source.Error, interface{}, error) {
|
|
v := act.handle.Get(ctx)
|
|
if v == nil {
|
|
return nil, nil, errors.Errorf("no analyses for %s", act.pkg.ID())
|
|
}
|
|
data := v.(*actionData)
|
|
return data.diagnostics, data.result, data.err
|
|
}
|
|
|
|
func (act *actionHandle) cached() ([]*source.Error, interface{}, error) {
|
|
v := act.handle.Cached()
|
|
if v == nil {
|
|
return nil, nil, errors.Errorf("no analyses for %s", act.pkg.ID())
|
|
}
|
|
data := v.(*actionData)
|
|
return data.diagnostics, data.result, data.err
|
|
}
|
|
|
|
func buildActionKey(a *analysis.Analyzer, cph *checkPackageHandle) string {
|
|
return hashContents([]byte(fmt.Sprintf("%p %s", a, string(cph.key))))
|
|
}
|
|
|
|
func (act *actionHandle) String() string {
|
|
return fmt.Sprintf("%s@%s", act.analyzer, act.pkg.PkgPath())
|
|
}
|
|
|
|
func execAll(ctx context.Context, fset *token.FileSet, actions []*actionHandle) (map[*actionHandle]*actionData, error) {
|
|
var mu sync.Mutex
|
|
results := make(map[*actionHandle]*actionData)
|
|
|
|
g, ctx := errgroup.WithContext(ctx)
|
|
for _, act := range actions {
|
|
act := act
|
|
g.Go(func() error {
|
|
v := act.handle.Get(ctx)
|
|
if v == nil {
|
|
return errors.Errorf("no analyses for %s", act.pkg.ID())
|
|
}
|
|
data, ok := v.(*actionData)
|
|
if !ok {
|
|
return errors.Errorf("unexpected type for %s: %T", act, v)
|
|
}
|
|
|
|
mu.Lock()
|
|
defer mu.Unlock()
|
|
results[act] = data
|
|
|
|
return nil
|
|
})
|
|
}
|
|
return results, g.Wait()
|
|
}
|
|
|
|
func runAnalysis(ctx context.Context, fset *token.FileSet, analyzer *analysis.Analyzer, pkg *pkg, deps map[*actionHandle]*actionData) ([]*source.Error, interface{}, map[objectFactKey]analysis.Fact, map[packageFactKey]analysis.Fact, error) {
|
|
// Plumb the output values of the dependencies
|
|
// into the inputs of this action. Also facts.
|
|
inputs := make(map[*analysis.Analyzer]interface{})
|
|
objectFacts := make(map[objectFactKey]analysis.Fact)
|
|
packageFacts := make(map[packageFactKey]analysis.Fact)
|
|
|
|
for depHandle, depData := range deps {
|
|
if depHandle.pkg == pkg {
|
|
// Same package, different analysis (horizontal edge):
|
|
// in-memory outputs of prerequisite analyzers
|
|
// become inputs to this analysis pass.
|
|
inputs[depHandle.analyzer] = depData.result
|
|
} else if depHandle.analyzer == analyzer { // (always true)
|
|
// Same analysis, different package (vertical edge):
|
|
// serialized facts produced by prerequisite analysis
|
|
// become available to this analysis pass.
|
|
for key, fact := range depData.objectFacts {
|
|
// Filter out facts related to objects
|
|
// that are irrelevant downstream
|
|
// (equivalently: not in the compiler export data).
|
|
if !exportedFrom(key.obj, depHandle.pkg.types) {
|
|
continue
|
|
}
|
|
objectFacts[key] = fact
|
|
}
|
|
for key, fact := range depData.packageFacts {
|
|
// TODO: filter out facts that belong to
|
|
// packages not mentioned in the export data
|
|
// to prevent side channels.
|
|
|
|
packageFacts[key] = fact
|
|
}
|
|
}
|
|
}
|
|
|
|
var diagnostics []*analysis.Diagnostic
|
|
|
|
// Run the analysis.
|
|
pass := &analysis.Pass{
|
|
Analyzer: analyzer,
|
|
Fset: fset,
|
|
Files: pkg.GetSyntax(),
|
|
Pkg: pkg.GetTypes(),
|
|
TypesInfo: pkg.GetTypesInfo(),
|
|
TypesSizes: pkg.GetTypesSizes(),
|
|
ResultOf: inputs,
|
|
Report: func(d analysis.Diagnostic) {
|
|
// Prefix the diagnostic category with the analyzer's name.
|
|
if d.Category == "" {
|
|
d.Category = analyzer.Name
|
|
} else {
|
|
d.Category = analyzer.Name + "." + d.Category
|
|
}
|
|
diagnostics = append(diagnostics, &d)
|
|
},
|
|
ImportObjectFact: func(obj types.Object, ptr analysis.Fact) bool {
|
|
if obj == nil {
|
|
panic("nil object")
|
|
}
|
|
key := objectFactKey{obj, factType(ptr)}
|
|
|
|
if v, ok := objectFacts[key]; ok {
|
|
reflect.ValueOf(ptr).Elem().Set(reflect.ValueOf(v).Elem())
|
|
return true
|
|
}
|
|
return false
|
|
},
|
|
ExportObjectFact: func(obj types.Object, fact analysis.Fact) {
|
|
if obj.Pkg() != pkg.types {
|
|
panic(fmt.Sprintf("internal error: in analysis %s of package %s: Fact.Set(%s, %T): can't set facts on objects belonging another package",
|
|
analyzer, pkg.ID(), obj, fact))
|
|
}
|
|
key := objectFactKey{obj, factType(fact)}
|
|
objectFacts[key] = fact // clobber any existing entry
|
|
},
|
|
ImportPackageFact: func(pkg *types.Package, ptr analysis.Fact) bool {
|
|
if pkg == nil {
|
|
panic("nil package")
|
|
}
|
|
key := packageFactKey{pkg, factType(ptr)}
|
|
if v, ok := packageFacts[key]; ok {
|
|
reflect.ValueOf(ptr).Elem().Set(reflect.ValueOf(v).Elem())
|
|
return true
|
|
}
|
|
return false
|
|
},
|
|
ExportPackageFact: func(fact analysis.Fact) {
|
|
key := packageFactKey{pkg.types, factType(fact)}
|
|
packageFacts[key] = fact // clobber any existing entry
|
|
},
|
|
AllObjectFacts: func() []analysis.ObjectFact {
|
|
facts := make([]analysis.ObjectFact, 0, len(objectFacts))
|
|
for k := range objectFacts {
|
|
facts = append(facts, analysis.ObjectFact{Object: k.obj, Fact: objectFacts[k]})
|
|
}
|
|
return facts
|
|
},
|
|
AllPackageFacts: func() []analysis.PackageFact {
|
|
facts := make([]analysis.PackageFact, 0, len(packageFacts))
|
|
for k := range packageFacts {
|
|
facts = append(facts, analysis.PackageFact{Package: k.pkg, Fact: packageFacts[k]})
|
|
}
|
|
return facts
|
|
},
|
|
}
|
|
|
|
if pkg.IsIllTyped() {
|
|
return nil, nil, nil, nil, errors.Errorf("analysis skipped due to errors in package: %v", pkg.GetErrors())
|
|
}
|
|
result, err := pass.Analyzer.Run(pass)
|
|
if err == nil {
|
|
if got, want := reflect.TypeOf(result), pass.Analyzer.ResultType; got != want {
|
|
err = errors.Errorf(
|
|
"internal error: on package %s, analyzer %s returned a result of type %v, but declared ResultType %v",
|
|
pass.Pkg.Path(), pass.Analyzer, got, want)
|
|
}
|
|
}
|
|
|
|
// disallow calls after Run
|
|
pass.ExportObjectFact = func(obj types.Object, fact analysis.Fact) {
|
|
panic(fmt.Sprintf("%s:%s: Pass.ExportObjectFact(%s, %T) called after Run", analyzer.Name, pkg.PkgPath(), obj, fact))
|
|
}
|
|
pass.ExportPackageFact = func(fact analysis.Fact) {
|
|
panic(fmt.Sprintf("%s:%s: Pass.ExportPackageFact(%T) called after Run", analyzer.Name, pkg.PkgPath(), fact))
|
|
}
|
|
|
|
var errors []*source.Error
|
|
for _, diag := range diagnostics {
|
|
srcErr, err := sourceError(ctx, fset, pkg, diag)
|
|
if err != nil {
|
|
return nil, nil, nil, nil, err
|
|
}
|
|
errors = append(errors, srcErr)
|
|
}
|
|
return errors, result, objectFacts, packageFacts, err
|
|
}
|
|
|
|
// exportedFrom reports whether obj may be visible to a package that imports pkg.
|
|
// This includes not just the exported members of pkg, but also unexported
|
|
// constants, types, fields, and methods, perhaps belonging to oether packages,
|
|
// that find there way into the API.
|
|
// This is an overapproximation of the more accurate approach used by
|
|
// gc export data, which walks the type graph, but it's much simpler.
|
|
//
|
|
// TODO(adonovan): do more accurate filtering by walking the type graph.
|
|
func exportedFrom(obj types.Object, pkg *types.Package) bool {
|
|
switch obj := obj.(type) {
|
|
case *types.Func:
|
|
return obj.Exported() && obj.Pkg() == pkg ||
|
|
obj.Type().(*types.Signature).Recv() != nil
|
|
case *types.Var:
|
|
return obj.Exported() && obj.Pkg() == pkg ||
|
|
obj.IsField()
|
|
case *types.TypeName, *types.Const:
|
|
return true
|
|
}
|
|
return false // Nil, Builtin, Label, or PkgName
|
|
}
|
|
|
|
func factType(fact analysis.Fact) reflect.Type {
|
|
t := reflect.TypeOf(fact)
|
|
if t.Kind() != reflect.Ptr {
|
|
panic(fmt.Sprintf("invalid Fact type: got %T, want pointer", t))
|
|
}
|
|
return t
|
|
}
|