mirror of
https://github.com/golang/go
synced 2024-11-18 15:44:41 -07:00
e8c291b808
benchcmp now preserves benchmark order. This restores the original misc/benchcmp behavior. This also makes the output of benchcmp stable, and groups together multiple -cpu results. Magnitude-based sorting is still available via the -mag flag. It is useful for surfacing items of note (particularly changes in allocs) when making compiler changes and running broad benchmarks. Fixes golang/go#7259. LGTM=dave R=dave, mtj CC=bradfitz, dvyukov, golang-codereviews https://golang.org/cl/60840045
132 lines
4.5 KiB
Go
132 lines
4.5 KiB
Go
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"math"
|
|
"reflect"
|
|
"sort"
|
|
"testing"
|
|
)
|
|
|
|
func TestDelta(t *testing.T) {
|
|
cases := []struct {
|
|
before float64
|
|
after float64
|
|
mag float64
|
|
f float64
|
|
changed bool
|
|
pct string
|
|
mult string
|
|
}{
|
|
{before: 1, after: 1, mag: 1, f: 1, changed: false, pct: "+0.00%", mult: "1.00x"},
|
|
{before: 1, after: 2, mag: 0.5, f: 2, changed: true, pct: "+100.00%", mult: "2.00x"},
|
|
{before: 2, after: 1, mag: 0.5, f: 0.5, changed: true, pct: "-50.00%", mult: "0.50x"},
|
|
{before: 0, after: 0, mag: 1, f: 1, changed: false, pct: "+0.00%", mult: "1.00x"},
|
|
{before: 1, after: 0, mag: math.Inf(1), f: 0, changed: true, pct: "-100.00%", mult: "0.00x"},
|
|
{before: 0, after: 1, mag: math.Inf(1), f: math.Inf(1), changed: true, pct: "+Inf%", mult: "+Infx"},
|
|
}
|
|
for _, tt := range cases {
|
|
d := Delta{tt.before, tt.after}
|
|
if want, have := tt.mag, d.mag(); want != have {
|
|
t.Errorf("%s.mag(): want %f have %f", d, want, have)
|
|
}
|
|
if want, have := tt.f, d.Float64(); want != have {
|
|
t.Errorf("%s.Float64(): want %f have %f", d, want, have)
|
|
}
|
|
if want, have := tt.changed, d.Changed(); want != have {
|
|
t.Errorf("%s.Changed(): want %t have %t", d, want, have)
|
|
}
|
|
if want, have := tt.pct, d.Percent(); want != have {
|
|
t.Errorf("%s.Percent(): want %q have %q", d, want, have)
|
|
}
|
|
if want, have := tt.mult, d.Multiple(); want != have {
|
|
t.Errorf("%s.Multiple(): want %q have %q", d, want, have)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCorrelate(t *testing.T) {
|
|
// Benches that are going to be successfully correlated get N thus:
|
|
// 0x<counter><num benches><b = before | a = after>
|
|
// Read this: "<counter> of <num benches>, from <before|after>".
|
|
before := BenchSet{
|
|
"BenchmarkOneEach": []*Bench{{Name: "BenchmarkOneEach", N: 0x11b}},
|
|
"BenchmarkOneToNone": []*Bench{{Name: "BenchmarkOneToNone"}},
|
|
"BenchmarkOneToTwo": []*Bench{{Name: "BenchmarkOneToTwo"}},
|
|
"BenchmarkTwoToOne": []*Bench{
|
|
{Name: "BenchmarkTwoToOne"},
|
|
{Name: "BenchmarkTwoToOne"},
|
|
},
|
|
"BenchmarkTwoEach": []*Bench{
|
|
{Name: "BenchmarkTwoEach", N: 0x12b},
|
|
{Name: "BenchmarkTwoEach", N: 0x22b},
|
|
},
|
|
}
|
|
|
|
after := BenchSet{
|
|
"BenchmarkOneEach": []*Bench{{Name: "BenchmarkOneEach", N: 0x11a}},
|
|
"BenchmarkNoneToOne": []*Bench{{Name: "BenchmarkNoneToOne"}},
|
|
"BenchmarkTwoToOne": []*Bench{{Name: "BenchmarkTwoToOne"}},
|
|
"BenchmarkOneToTwo": []*Bench{
|
|
{Name: "BenchmarkOneToTwo"},
|
|
{Name: "BenchmarkOneToTwo"},
|
|
},
|
|
"BenchmarkTwoEach": []*Bench{
|
|
{Name: "BenchmarkTwoEach", N: 0x12a},
|
|
{Name: "BenchmarkTwoEach", N: 0x22a},
|
|
},
|
|
}
|
|
|
|
pairs, errs := Correlate(before, after)
|
|
|
|
// Fail to match: BenchmarkOneToNone, BenchmarkOneToTwo, BenchmarkTwoToOne.
|
|
// Correlate does not notice BenchmarkNoneToOne.
|
|
if len(errs) != 3 {
|
|
t.Errorf("Correlated expected 4 errors, got %d: %v", len(errs), errs)
|
|
}
|
|
|
|
// Want three correlated pairs: one BenchmarkOneEach, two BenchmarkTwoEach.
|
|
if len(pairs) != 3 {
|
|
t.Fatalf("Correlated expected 3 pairs, got %v", pairs)
|
|
}
|
|
|
|
for _, pair := range pairs {
|
|
if pair.Before.N&0xF != 0xb {
|
|
t.Errorf("unexpected Before in pair %s", pair)
|
|
}
|
|
if pair.After.N&0xF != 0xa {
|
|
t.Errorf("unexpected After in pair %s", pair)
|
|
}
|
|
if pair.Before.N>>4 != pair.After.N>>4 {
|
|
t.Errorf("mismatched pair %s", pair)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBenchCmpSorting(t *testing.T) {
|
|
c := []BenchCmp{
|
|
{&Bench{Name: "BenchmarkMuchFaster", NsOp: 10, ord: 3}, &Bench{Name: "BenchmarkMuchFaster", NsOp: 1}},
|
|
{&Bench{Name: "BenchmarkSameB", NsOp: 5, ord: 1}, &Bench{Name: "BenchmarkSameB", NsOp: 5}},
|
|
{&Bench{Name: "BenchmarkSameA", NsOp: 5, ord: 2}, &Bench{Name: "BenchmarkSameA", NsOp: 5}},
|
|
{&Bench{Name: "BenchmarkSlower", NsOp: 10, ord: 0}, &Bench{Name: "BenchmarkSlower", NsOp: 11}},
|
|
}
|
|
|
|
// Test just one magnitude-based sort order; they are symmetric.
|
|
sort.Sort(ByDeltaNsOp(c))
|
|
want := []string{"BenchmarkMuchFaster", "BenchmarkSlower", "BenchmarkSameA", "BenchmarkSameB"}
|
|
have := []string{c[0].Name(), c[1].Name(), c[2].Name(), c[3].Name()}
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("ByDeltaNsOp incorrect sorting: want %v have %v", want, have)
|
|
}
|
|
|
|
sort.Sort(ByParseOrder(c))
|
|
want = []string{"BenchmarkSlower", "BenchmarkSameB", "BenchmarkSameA", "BenchmarkMuchFaster"}
|
|
have = []string{c[0].Name(), c[1].Name(), c[2].Name(), c[3].Name()}
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("ByParseOrder incorrect sorting: want %v have %v", want, have)
|
|
}
|
|
}
|