1
0
mirror of https://github.com/golang/go synced 2024-11-15 00:10:28 -07:00
go/src/cmd/vet
Josh Bleecher Snyder 73912a1b91 cmd/vet: remove Peek from list of canonical methods
It is insufficiently canonical;
see the discussion at issue 19719.

Fixes #19719

Change-Id: I0559ff3b1b39d7bc4b446d104f36fdf8ce3da50e
Reviewed-on: https://go-review.googlesource.com/38722
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
2017-03-27 23:36:36 +00:00
..
all cmd/internal/obj: make x86's asmbuf a local variable 2017-03-26 04:12:26 +00:00
internal
testdata cmd/vet: check shift calculations with "unsafe" package 2017-03-13 22:30:27 +00:00
asmdecl.go cmd/vet: use types.SizesFor 2017-03-02 17:13:36 +00:00
assign.go
atomic.go
bool.go
buildtag.go
cgo.go
composite.go
copylock.go cmd/vet: include function name or value in copylock message 2017-01-03 19:23:23 +00:00
deadcode.go
doc.go cmd/vet: support importing from source 2017-03-02 18:43:23 +00:00
httpresponse.go cmd/vet: refactor to support alternative importers 2017-03-02 18:43:12 +00:00
lostcancel.go cmd/vet: -lostcancel: fix crash in ill-typed code 2017-03-22 17:04:35 +00:00
main.go cmd/vet: support importing from source 2017-03-02 18:43:23 +00:00
method.go cmd/vet: remove Peek from list of canonical methods 2017-03-27 23:36:36 +00:00
nilfunc.go
print.go
rangeloop.go
README
shadow.go
shift.go cmd/vet: check shift calculations with "unsafe" package 2017-03-13 22:30:27 +00:00
structtag.go
tests.go
types.go cmd/vet: eliminate "might be too small for shift" warnings 2017-03-11 15:29:30 +00:00
unsafeptr.go
unused.go
vet_test.go

Vet is a tool that checks correctness of Go programs. It runs a suite of tests,
each tailored to check for a particular class of errors. Examples include incorrect
Printf format verbs or malformed build tags.

Over time many checks have been added to vet's suite, but many more have been
rejected as not appropriate for the tool. The criteria applied when selecting which
checks to add are:

Correctness:

Vet's tools are about correctness, not style. A vet check must identify real or
potential bugs that could cause incorrect compilation or execution. A check that
only identifies stylistic points or alternative correct approaches to a situation
is not acceptable.

Frequency:

Vet is run every day by many programmers, often as part of every compilation or
submission. The cost in execution time is considerable, especially in aggregate,
so checks must be likely enough to find real problems that they are worth the
overhead of the added check. A new check that finds only a handful of problems
across all existing programs, even if the problem is significant, is not worth
adding to the suite everyone runs daily.

Precision:

Most of vet's checks are heuristic and can generate both false positives (flagging
correct programs) and false negatives (not flagging incorrect ones). The rate of
both these failures must be very small. A check that is too noisy will be ignored
by the programmer overwhelmed by the output; a check that misses too many of the
cases it's looking for will give a false sense of security. Neither is acceptable.
A vet check must be accurate enough that everything it reports is worth examining,
and complete enough to encourage real confidence.