e7db792fc5
Currently this test attempts to trigger a concurrent GC in a very indirect way, but the way it does so is extremely error-prone. This test is virtually always prone to flaking based on test order. For example if the test that executed immediately before this one made a big heap but didn't clean it up, then this test could easily fail to trigger a GC. I was able to prove this with a small reproducer. This roundabout way of triggering a GC is also way overkill for this test. It just wants to get goroutines in a select and shrink their stacks. Every GC will schedule a stack for shrinking if it can. Replace all the complicated machinery with a single runtime.GC call. I've confirmed that the test consistently triggers a stack shrink, noting that both shrinkstack's copystack call is made and that syncadjustsudogs (the relevant function that's being indirectly tested) are both called. Fixes #44610. Change-Id: Ib1c091e0d1475bf6c596f56dc9b85eaea366fc73 Reviewed-on: https://go-review.googlesource.com/c/go/+/313109 Trust: Michael Knyszek <mknyszek@google.com> Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.