1
0
mirror of https://github.com/golang/go synced 2024-11-18 20:44:45 -07:00
go/imports
Heschi Kreinick 8a60511975 imports: don't look for, or find, empty packages
Fix a pair of bugs that combined to cause golang/go#29520. First, don't go
looking for a package if we've only seen unexported identifiers selected
from it. It's probably a typo. Second, don't find packages with no files
in them, e.g. because they're all build tagged out. We can't know what
package they form, so we have no business considering them.

Test only for the first, since without the first bug the second has no
observable effect on behavior, and I don't want to test the private API.

Fixes golang/go#29520

Change-Id: I5b797940bec051be5945b9c5cb4e7bf28527a939
Reviewed-on: https://go-review.googlesource.com/c/156178
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-01-03 20:59:43 +00:00
..
fix_test.go imports: don't look for, or find, empty packages 2019-01-03 20:59:43 +00:00
fix.go imports: don't look for, or find, empty packages 2019-01-03 20:59:43 +00:00
imports.go imports: redesign fixImports 2018-12-03 18:26:12 +00:00
mkindex.go go.tools/imports: move goimports from github to go.tools. 2013-12-17 21:21:03 -05:00
mkstdlib.go imports: redesign fixImports 2018-12-03 18:26:12 +00:00
sortimports.go Revert "imports: support repairing import grouping/ordering" 2018-10-24 17:12:08 +00:00
zstdlib.go imports: redesign fixImports 2018-12-03 18:26:12 +00:00