mirror of
https://github.com/golang/go
synced 2024-11-25 15:27:57 -07:00
d89705e087
When exporting signature types, we include the originating package, because it's exposed via go/types's API. And as a consistency check, we ensure that the parameter names came from that same package. However, we were getting this wrong in the case of exported variables that were initialized with a method value using an imported method. In this case, when we created the method value wrapper function's type (which is reused as the variable's type if none is explicitly provided in the variable declaration), we were reusing the original (i.e., imported) parameter names, but the newly created signature type was associated with the current package instead. The correct fix here is really to preserve the original signature type's package (along with position and name for its parameters), but that's awkward to do at the moment because the DeclFunc API requires an ir representation of the function signature, whereas we only provide a way to explicitly set packages via the type constructor APIs. As an interim fix, we associate the parameters with the current package, to be consistent with the signature type's package. Fixes #43479. Change-Id: Id45a10f8cf64165c9bc7d9598f0a0ee199a5e752 Reviewed-on: https://go-review.googlesource.com/c/go/+/281292 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
28 lines
466 B
Go
28 lines
466 B
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package a
|
|
|
|
type Here struct{ stuff int }
|
|
type Info struct{ Dir string }
|
|
|
|
func New() Here { return Here{} }
|
|
func (h Here) Dir(p string) (Info, error)
|
|
|
|
type I interface{ M(x string) }
|
|
|
|
type T = struct {
|
|
Here
|
|
I
|
|
}
|
|
|
|
var X T
|
|
|
|
var A = (*T).Dir
|
|
var B = T.Dir
|
|
var C = X.Dir
|
|
var D = (*T).M
|
|
var E = T.M
|
|
var F = X.M
|