1
0
mirror of https://github.com/golang/go synced 2024-09-30 00:14:36 -06:00
go/misc/cgo
Austin Clements e612d212c6 misc/cgo/testasan: drop test
The testasan test was added back in 2013 (CL 10126044), many years
before Go added ASAN support in 2021 (CL 298611). So, in fact,
testasan does not test Go ASAN support at all, as you might expect
(misc/cgo/testsanitizers does that). It's intended to test whether the
Go memory allocator works in a mixed C/Go binary where the C code is
compiled with ASAN. The test doesn't actually use ASAN in any way; it
just simulates where ASAN of 2013 put its shadow mappings. This made
sense to test at the time because Go was picky about where its heap
landed and ASAN happened to put its mappings exactly where Go wanted
to put its heap. These days, Go is totally flexible about its heap
placement, and I wouldn't be surprised if ASAN also works differently.

Given all of this, this test adds almost no value today. Drop it.

For #37486, since it eliminates a non-go-test from dist.

Change-Id: I0292f8efbdc0e1e39650715604535c445fbaa87f
Reviewed-on: https://go-review.googlesource.com/c/go/+/443067
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Austin Clements <austin@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-10-14 20:17:35 +00:00
..
errors misc/cgo: replace ioutil.ReadFile with os.ReadFile 2022-09-19 16:55:59 +00:00
fortran
gmp all: gofmt main repo 2022-04-11 16:34:30 +00:00
life
nocgo
stdio
test misc/cgo/test: disable setgid tests with musl 2022-08-22 14:48:53 +00:00
testcarchive misc/cgo: replace os.SEEK_SET with io.SeekStart 2022-09-19 16:55:26 +00:00
testcshared all: disable tests that fail on Alpine 2022-08-02 17:23:42 +00:00
testgodefs cmd/cgo: retain original file paths in godefs generated comment 2022-04-03 07:18:10 +00:00
testplugin cmd/compile: make jump table symbol local 2022-07-22 20:12:19 +00:00
testsanitizers cmd/dist, misc/cgo/testsanitizers: enable msan tests on freebsd/amd64 2022-10-14 12:48:50 +00:00
testshared test: skip -buildmode=pie tests on alpine 2022-08-09 15:13:01 +00:00
testsigfwd
testso all: gofmt more (but vendor, testdata, and top-level test directories) 2021-08-13 20:45:17 +00:00
testsovar all: gofmt more (but vendor, testdata, and top-level test directories) 2021-08-13 20:45:17 +00:00
testtls all: gofmt more (but vendor, testdata, and top-level test directories) 2021-08-13 20:45:17 +00:00