1
0
mirror of https://github.com/golang/go synced 2024-11-26 21:11:57 -07:00
go/misc
Bryan C. Mills e57350f4c0 runtime: fix _cgo_yield usage with sysmon and on BSD
There are a few problems from change 35494, discovered during testing
of change 37852.

1. I was confused about the usage of n.key in the sema variant, so we
   were looping on the wrong condition. The error was not caught by
   the TryBots (presumably due to missing TSAN coverage in the BSD and
   darwin builders?).

2. The sysmon goroutine sometimes skips notetsleep entirely, using
   direct usleep syscalls instead. In that case, we were not calling
   _cgo_yield, leading to missed signals under TSAN.

3. Some notetsleep calls have long finite timeouts. They should be
   broken up into smaller chunks with a yield at the end of each
   chunk.

updates #18717

Change-Id: I91175af5dea3857deebc686f51a8a40f9d690bcc
Reviewed-on: https://go-review.googlesource.com/37867
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2017-03-09 18:36:49 +00:00
..
android misc/android: make the exec wrapper exit code parsing more robust 2016-06-08 05:24:53 +00:00
arm all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
cgo runtime: fix _cgo_yield usage with sysmon and on BSD 2017-03-09 18:36:49 +00:00
chrome/gophertool
git misc/git: Fix non-literal period in pre-commit grep 2016-02-26 19:06:38 +00:00
ios misc/ios,cmd/go, runtime/cgo: fix iOS test harness (again) 2017-03-04 01:43:13 +00:00
linkcheck
nacl cmd/pprof: vendor pprof from github.com/google/pprof 2017-02-24 19:18:53 +00:00
sortac
swig all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
trace misc/trace: disable trace resolution warning 2016-07-21 18:17:31 +00:00
benchcmp
editors