mirror of
https://github.com/golang/go
synced 2024-11-05 15:46:11 -07:00
f8e42dc477
We expected URIs to be canonical, but VS Code's URI escaping is overeager and escapes things that don't need to be. Forcibly unescape them, then re-escape them with Go's encoding, so that we know they'll match URIs generated by URIFromPath. Fixes golang/go#37231. Change-Id: I4b163ae3c91e8846ab72e5b5e89bd6d018c3995e Reviewed-on: https://go-review.googlesource.com/c/tools/+/219899 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
112 lines
3.1 KiB
Go
112 lines
3.1 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// +build windows
|
|
|
|
package span_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"golang.org/x/tools/internal/span"
|
|
)
|
|
|
|
// TestURI tests the conversion between URIs and filenames. The test cases
|
|
// include Windows-style URIs and filepaths, but we avoid having OS-specific
|
|
// tests by using only forward slashes, assuming that the standard library
|
|
// functions filepath.ToSlash and filepath.FromSlash do not need testing.
|
|
func TestURIFromPath(t *testing.T) {
|
|
for _, test := range []struct {
|
|
path, wantFile string
|
|
wantURI span.URI
|
|
}{
|
|
{
|
|
path: ``,
|
|
wantFile: ``,
|
|
wantURI: span.URI(""),
|
|
},
|
|
{
|
|
path: `C:\Windows\System32`,
|
|
wantFile: `C:\Windows\System32`,
|
|
wantURI: span.URI("file:///C:/Windows/System32"),
|
|
},
|
|
{
|
|
path: `C:\Go\src\bob.go`,
|
|
wantFile: `C:\Go\src\bob.go`,
|
|
wantURI: span.URI("file:///C:/Go/src/bob.go"),
|
|
},
|
|
{
|
|
path: `c:\Go\src\bob.go`,
|
|
wantFile: `C:\Go\src\bob.go`,
|
|
wantURI: span.URI("file:///C:/Go/src/bob.go"),
|
|
},
|
|
{
|
|
path: `\path\to\dir`,
|
|
wantFile: `C:\path\to\dir`,
|
|
wantURI: span.URI("file:///C:/path/to/dir"),
|
|
},
|
|
{
|
|
path: `\a\b\c\src\bob.go`,
|
|
wantFile: `C:\a\b\c\src\bob.go`,
|
|
wantURI: span.URI("file:///C:/a/b/c/src/bob.go"),
|
|
},
|
|
{
|
|
path: `c:\Go\src\bob george\george\george.go`,
|
|
wantFile: `C:\Go\src\bob george\george\george.go`,
|
|
wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"),
|
|
},
|
|
} {
|
|
got := span.URIFromPath(test.path)
|
|
if got != test.wantURI {
|
|
t.Errorf("URIFromPath(%q): got %q, expected %q", test.path, got, test.wantURI)
|
|
}
|
|
gotFilename := got.Filename()
|
|
if gotFilename != test.wantFile {
|
|
t.Errorf("Filename(%q): got %q, expected %q", got, gotFilename, test.wantFile)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestURIFromURI(t *testing.T) {
|
|
for _, test := range []struct {
|
|
inputURI, wantFile string
|
|
wantURI span.URI
|
|
}{
|
|
{
|
|
inputURI: `file:///c:/Go/src/bob%20george/george/george.go`,
|
|
wantFile: `C:\Go\src\bob george\george\george.go`,
|
|
wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"),
|
|
},
|
|
{
|
|
inputURI: `file:///C%3A/Go/src/bob%20george/george/george.go`,
|
|
wantFile: `C:\Go\src\bob george\george\george.go`,
|
|
wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"),
|
|
},
|
|
{
|
|
inputURI: `file:///c:/path/to/%25p%25ercent%25/per%25cent.go`,
|
|
wantFile: `C:\path\to\%p%ercent%\per%cent.go`,
|
|
wantURI: span.URI(`file:///C:/path/to/%25p%25ercent%25/per%25cent.go`),
|
|
},
|
|
{
|
|
inputURI: `file:///C%3A/`,
|
|
wantFile: `C:\`,
|
|
wantURI: span.URI(`file:///C:/`),
|
|
},
|
|
{
|
|
inputURI: `file:///`,
|
|
wantFile: `\`,
|
|
wantURI: span.URI(`file:///`),
|
|
},
|
|
} {
|
|
got := span.URIFromURI(test.inputURI)
|
|
if got != test.wantURI {
|
|
t.Errorf("NewURI(%q): got %q, expected %q", test.inputURI, got, test.wantURI)
|
|
}
|
|
gotFilename := got.Filename()
|
|
if gotFilename != test.wantFile {
|
|
t.Errorf("Filename(%q): got %q, expected %q", got, gotFilename, test.wantFile)
|
|
}
|
|
}
|
|
}
|