Rob Findley de023d59a5 internal/lsp/protocol: unmarshal to pointers when dispatching requests ... With #34111, we are forwarding the LSP from one gopls instance to another. This exposed an asymmetry in our LSP dispatching: for both ClientDispatcher and ServerDispatcher, we unmarshal to non-nil response structs. This means that when forwarding the LSP, we translate empty JSON responses (corresponding to nil values) into the non-nil zero value. This causes problems for some editors, as reported in #37570. Fix it by instead unmarshaling to a pointer. This is, of course, a somewhat dangerous change. I fixed the one NPE that occurred in tests, and have done some mild manual testing. I wouldn't be surprised if we discover more NPEs later on, but I still think this is the right change to make. Updates golang/go#34111 Fixes golang/go#37570 Change-Id: Ie69e92d2821c829cdfc4f4ab303679a725f1f859 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222058 Reviewed-by: Peter Weinberger <pjw@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>		2020-03-05 22:45:36 +00:00
..
definition_test.go	internal/lsp/regtest: remove calls to t.Parallel()	2020-02-27 18:46:34 +00:00
diagnostics_test.go	internal/lsp/regtest: add a test for diagnostics on first file	2020-03-02 22:55:59 +00:00
env.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
formatting_test.go	internal/lsp/regtest: implement formatting and organizeImports	2020-03-02 19:16:53 +00:00
reg_test.go	internal/lsp/regtest: clean-up and more error handling	2020-02-25 19:00:36 +00:00
serialization_test.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
shared_test.go	internal/lsp/regtest: remove calls to t.Parallel()	2020-02-27 18:46:34 +00:00
wrappers.go	internal/lsp/regtest: implement formatting and organizeImports	2020-03-02 19:16:53 +00:00