Paul Jolly e48fac377d internal/lsp: change workspace symbols to use session config for matcher ... WorkspaceSymbols matches symbols across views using the given query, according to the matcher Matcher. The workspace symbol method is defined in the spec as follows: > The workspace symbol request is sent from the client to the server to > list project-wide symbols matching the query string. It is unclear what "project-wide" means here, but given the parameters of workspace/symbol do not include any workspace identifier, then it has to be assumed that "project-wide" means "across all workspaces". Hence why WorkspaceSymbols receives the views []View. However, it then becomes unclear what it would mean to call WorkspaceSymbols with a different configured Matcher per View. Therefore we assume that Session level configuration will define the Matcher to be used for the WorkspaceSymbols method. As part of this change we also tidy up lsp_test.go and source_test.go to remove some repetition. Change-Id: I444f9a78303ac9d2c8d8ac6496603b5758e4aafd Reviewed-on: https://go-review.googlesource.com/c/tools/+/228763 Run-TryBot: Paul Jolly <paul@myitcv.org.uk> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-05-11 19:21:19 +00:00
..
code_lens.go	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_format.go	internal/lsp: handle different package names in signature help	2020-04-27 20:59:12 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer completion "if err != nil { return err }"	2020-03-10 21:06:53 +00:00
completion.go	internal/lsp: return early in completion where possible	2020-05-07 20:50:54 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: make sure diagnostics only refer to existing files	2020-05-07 02:01:22 +00:00
folding_range.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
format_test.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
format.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
highlight.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
hover.go	internal/lsp: handle hover documentation for package declarations	2020-04-29 20:57:41 +00:00
identifier.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
implementation.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
options.go	internal/lsp/source: use the setString method when setting options	2020-05-08 18:47:48 +00:00
references.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
rename_check.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
rename.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
signature_help.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
source_test.go	internal/lsp: change workspace symbols to use session config for matcher	2020-05-11 19:21:19 +00:00
symbols.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
types_format.go	internal/lsp: return in the default case in cloneExpr	2020-05-09 03:07:07 +00:00
util.go	internal/lsp: refactor code for formatting signatures	2020-04-22 20:52:58 +00:00
view.go	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
workspace_symbol.go	internal/lsp: change workspace symbols to use session config for matcher	2020-05-11 19:21:19 +00:00