Rebecca Stambler e31b568ad1 internal/lsp: plumb fillstruct through analysis ... Now that fillstruct is an analyzer, we can simplify the code that calls it in code_action.go. We introduce a new class of analyzer -- convenience analyzers, which are closer to commands. These represent suggestions that won't necessarily improve the quality or correctness of your code, but they offer small helper functions for the user. This CL also combines the refactor rewrite tests with the suggested fix tests, since they are effectively the same. For now, we only support convenience analyzers when a code action was requested on the same line as the fix. I'm not sure how to otherwise handle this without bothering the user with unnecessary diagnostics. Change-Id: I7f0aa198b5ee9964a907d709bae6380093d4ef21 Reviewed-on: https://go-review.googlesource.com/c/tools/+/237687 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>		2020-06-15 21:22:08 +00:00
..
check.go	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
cmdtest.go	internal/lsp: change logging stream to be a framer	2020-06-03 13:12:46 +00:00
definition.go	internal/lsp/cmd: fix the command line query for definition	2020-04-27 20:15:23 +00:00
folding_range.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
format.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
highlight.go	tools/gopls: add cmd support for highlight	2019-11-26 20:36:08 +00:00
implementation.go	internal/lsp: store workspace package IDs with package paths	2020-01-09 22:04:34 +00:00
imports.go	internal/lsp: fix imports issue with duplicate package decl	2020-04-16 06:17:24 +00:00
links.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
prepare_rename.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
references.go	internal/lsp: add tests for references includeDeclaration setting	2020-01-23 01:39:50 +00:00
rename.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
signature.go	internal/lsp: remove unnecessary source.SignatureInformation type	2020-02-06 19:05:38 +00:00
suggested_fix.go	internal/lsp: plumb fillstruct through analysis	2020-06-15 21:22:08 +00:00
symbols.go	internal/lsp: fix a race in the command line tests	2019-11-22 16:15:56 +00:00
workspace_symbol.go	tools/gopls: add cmd support for workspace_symbol	2020-03-26 19:59:04 +00:00