mirror of
https://github.com/golang/go
synced 2024-11-18 22:44:48 -07:00
e33b02e766
This change adds support for returning versions along with file URIs, so that the client can know when to apply changes. The version is not yet propagated along to the internal/lsp/cache package, so this change will have no effect (VS Code ignores a version of 0 and still applies the changes). A few minor changes made in the rename code (to remove the view parameter). Some minor staticcheck fixes. Updates golang/go#35243 Change-Id: Icc26bd9d9e5703c699f555424b94034c97b01d6f Reviewed-on: https://go-review.googlesource.com/c/tools/+/206882 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
242 lines
6.7 KiB
Go
242 lines
6.7 KiB
Go
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package source
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"golang.org/x/tools/go/analysis"
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
|
"golang.org/x/tools/internal/lsp/telemetry"
|
|
"golang.org/x/tools/internal/span"
|
|
"golang.org/x/tools/internal/telemetry/log"
|
|
"golang.org/x/tools/internal/telemetry/trace"
|
|
)
|
|
|
|
type Diagnostic struct {
|
|
URI span.URI
|
|
Range protocol.Range
|
|
Message string
|
|
Source string
|
|
Severity protocol.DiagnosticSeverity
|
|
Tags []protocol.DiagnosticTag
|
|
|
|
SuggestedFixes []SuggestedFix
|
|
Related []RelatedInformation
|
|
}
|
|
|
|
type SuggestedFix struct {
|
|
Title string
|
|
Edits map[span.URI][]protocol.TextEdit
|
|
}
|
|
|
|
type RelatedInformation struct {
|
|
URI span.URI
|
|
Range protocol.Range
|
|
Message string
|
|
}
|
|
|
|
func Diagnostics(ctx context.Context, view View, f File, disabledAnalyses map[string]struct{}) (map[span.URI][]Diagnostic, string, error) {
|
|
ctx, done := trace.StartSpan(ctx, "source.Diagnostics", telemetry.File.Of(f.URI()))
|
|
defer done()
|
|
|
|
snapshot, cphs, err := view.CheckPackageHandles(ctx, f)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
cph, err := WidestCheckPackageHandle(cphs)
|
|
if err != nil {
|
|
return nil, "", err
|
|
}
|
|
|
|
// If we are missing dependencies, it may because the user's workspace is
|
|
// not correctly configured. Report errors, if possible.
|
|
var warningMsg string
|
|
if len(cph.MissingDependencies()) > 0 {
|
|
warningMsg, err = checkCommonErrors(ctx, view, f.URI())
|
|
if err != nil {
|
|
log.Error(ctx, "error checking common errors", err, telemetry.File.Of(f.URI))
|
|
}
|
|
}
|
|
pkg, err := cph.Check(ctx)
|
|
if err != nil {
|
|
log.Error(ctx, "no package for file", err)
|
|
return singleDiagnostic(f.URI(), "%s is not part of a package", f.URI()), "", nil
|
|
}
|
|
|
|
// Prepare the reports we will send for the files in this package.
|
|
reports := make(map[span.URI][]Diagnostic)
|
|
for _, fh := range pkg.Files() {
|
|
clearReports(view, reports, fh.File().Identity().URI)
|
|
}
|
|
|
|
// Prepare any additional reports for the errors in this package.
|
|
for _, err := range pkg.GetErrors() {
|
|
if err.Kind != ListError {
|
|
continue
|
|
}
|
|
clearReports(view, reports, err.URI)
|
|
}
|
|
|
|
// Run diagnostics for the package that this URI belongs to.
|
|
if !diagnostics(ctx, view, pkg, reports) {
|
|
// If we don't have any list, parse, or type errors, run analyses.
|
|
if err := analyses(ctx, snapshot, cph, disabledAnalyses, reports); err != nil {
|
|
log.Error(ctx, "failed to run analyses", err, telemetry.File.Of(f.URI()))
|
|
}
|
|
}
|
|
// Updates to the diagnostics for this package may need to be propagated.
|
|
revDeps := view.GetActiveReverseDeps(ctx, f)
|
|
for _, cph := range revDeps {
|
|
pkg, err := cph.Check(ctx)
|
|
if err != nil {
|
|
return nil, warningMsg, err
|
|
}
|
|
for _, fh := range pkg.Files() {
|
|
clearReports(view, reports, fh.File().Identity().URI)
|
|
}
|
|
diagnostics(ctx, view, pkg, reports)
|
|
}
|
|
return reports, warningMsg, nil
|
|
}
|
|
|
|
type diagnosticSet struct {
|
|
listErrors, parseErrors, typeErrors []*Diagnostic
|
|
}
|
|
|
|
func diagnostics(ctx context.Context, view View, pkg Package, reports map[span.URI][]Diagnostic) bool {
|
|
ctx, done := trace.StartSpan(ctx, "source.diagnostics", telemetry.Package.Of(pkg.ID()))
|
|
_ = ctx // circumvent SA4006
|
|
defer done()
|
|
|
|
diagSets := make(map[span.URI]*diagnosticSet)
|
|
for _, err := range pkg.GetErrors() {
|
|
diag := &Diagnostic{
|
|
URI: err.URI,
|
|
Message: err.Message,
|
|
Range: err.Range,
|
|
Severity: protocol.SeverityError,
|
|
}
|
|
set, ok := diagSets[diag.URI]
|
|
if !ok {
|
|
set = &diagnosticSet{}
|
|
diagSets[diag.URI] = set
|
|
}
|
|
switch err.Kind {
|
|
case ParseError:
|
|
set.parseErrors = append(set.parseErrors, diag)
|
|
diag.Source = "syntax"
|
|
case TypeError:
|
|
set.typeErrors = append(set.typeErrors, diag)
|
|
diag.Source = "compiler"
|
|
case ListError:
|
|
set.listErrors = append(set.listErrors, diag)
|
|
diag.Source = "go list"
|
|
}
|
|
}
|
|
var nonEmptyDiagnostics bool // track if we actually send non-empty diagnostics
|
|
for uri, set := range diagSets {
|
|
// Don't report type errors if there are parse errors or list errors.
|
|
diags := set.typeErrors
|
|
if len(set.parseErrors) > 0 {
|
|
diags = set.parseErrors
|
|
} else if len(set.listErrors) > 0 {
|
|
diags = set.listErrors
|
|
}
|
|
if len(diags) > 0 {
|
|
nonEmptyDiagnostics = true
|
|
}
|
|
for _, diag := range diags {
|
|
if _, ok := reports[uri]; ok {
|
|
reports[uri] = append(reports[uri], *diag)
|
|
}
|
|
}
|
|
}
|
|
return nonEmptyDiagnostics
|
|
}
|
|
|
|
func analyses(ctx context.Context, snapshot Snapshot, cph CheckPackageHandle, disabledAnalyses map[string]struct{}, reports map[span.URI][]Diagnostic) error {
|
|
var analyzers []*analysis.Analyzer
|
|
for _, a := range snapshot.View().Options().Analyzers {
|
|
if _, ok := disabledAnalyses[a.Name]; ok {
|
|
continue
|
|
}
|
|
analyzers = append(analyzers, a)
|
|
}
|
|
|
|
diagnostics, err := snapshot.Analyze(ctx, cph.ID(), analyzers)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Report diagnostics and errors from root analyzers.
|
|
for _, e := range diagnostics {
|
|
// This is a bit of a hack, but clients > 3.15 will be able to grey out unnecessary code.
|
|
// If we are deleting code as part of all of our suggested fixes, assume that this is dead code.
|
|
// TODO(golang/go/#34508): Return these codes from the diagnostics themselves.
|
|
var tags []protocol.DiagnosticTag
|
|
if onlyDeletions(e.SuggestedFixes) {
|
|
tags = append(tags, protocol.Unnecessary)
|
|
}
|
|
addReport(snapshot.View(), reports, Diagnostic{
|
|
URI: e.URI,
|
|
Range: e.Range,
|
|
Message: e.Message,
|
|
Source: e.Category,
|
|
Severity: protocol.SeverityWarning,
|
|
Tags: tags,
|
|
SuggestedFixes: e.SuggestedFixes,
|
|
Related: e.Related,
|
|
})
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func clearReports(v View, reports map[span.URI][]Diagnostic, uri span.URI) {
|
|
if v.Ignore(uri) {
|
|
return
|
|
}
|
|
reports[uri] = []Diagnostic{}
|
|
}
|
|
|
|
func addReport(v View, reports map[span.URI][]Diagnostic, diagnostic Diagnostic) {
|
|
if v.Ignore(diagnostic.URI) {
|
|
return
|
|
}
|
|
if _, ok := reports[diagnostic.URI]; ok {
|
|
reports[diagnostic.URI] = append(reports[diagnostic.URI], diagnostic)
|
|
}
|
|
}
|
|
|
|
func singleDiagnostic(uri span.URI, format string, a ...interface{}) map[span.URI][]Diagnostic {
|
|
return map[span.URI][]Diagnostic{
|
|
uri: []Diagnostic{{
|
|
Source: "LSP",
|
|
URI: uri,
|
|
Range: protocol.Range{},
|
|
Message: fmt.Sprintf(format, a...),
|
|
Severity: protocol.SeverityError,
|
|
}},
|
|
}
|
|
}
|
|
|
|
// onlyDeletions returns true if all of the suggested fixes are deletions.
|
|
func onlyDeletions(fixes []SuggestedFix) bool {
|
|
for _, fix := range fixes {
|
|
for _, edits := range fix.Edits {
|
|
for _, edit := range edits {
|
|
if edit.NewText != "" {
|
|
return false
|
|
}
|
|
if protocol.ComparePosition(edit.Range.Start, edit.Range.End) == 0 {
|
|
return false
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return true
|
|
}
|