1
0
mirror of https://github.com/golang/go synced 2024-11-25 08:17:58 -07:00
go/misc/cgo/errors
Bryan C. Mills 3c4c10ea8c misc/cgo: fix aliasing bugs in parallel tests that append to shared slices
These tests use a slice to represent the base C compiler command (with
flags). Appending to that slice can cause subtle aliasing bugs, such
as commands that silently corrupt the arguments of other concurrent
commands in parallel tests.

In this change, we explicitly reduce the capacity of the command slice
to force appends to it to always allocate unique new slices.

Fixes #49693

Change-Id: Ide466bf65f12cb6cead3dcba69f513cccb60a160
Reviewed-on: https://go-review.googlesource.com/c/go/+/383754
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-02-07 17:51:57 +00:00
..
testdata [dev.typeparams] all: add GOEXPERIMENT=unified knob 2021-06-17 09:09:02 +00:00
argposition_test.go cmd/cgo: pass end position info for C function arguments. 2021-04-05 19:29:17 +00:00
badsym_test.go misc/cgo: fix aliasing bugs in parallel tests that append to shared slices 2022-02-07 17:51:57 +00:00
errors_test.go all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
ptr_test.go all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00