Heschi Kreinick e31c80b82c all: rework goimports environment, support GOMODCACHE ... This CL got away from me a little. For a number of reasons, the existing goimports API of passing in values for various GO* values was not working. For one, the number of necessary variables kept growing. For another, we tried to avoid calling `go env` in GOPATH mode by using `build.Default`, but that turns out to be buggy; see golang/go#39838. And finally, it created massive confusion about whether the values were intended to be read from the OS environment, or fully evaluated by the `go` command. There are only two users of the internal imports API, so there really shouldn't need to be more than two modes. For the command line tool, we have to call `go env` to deal with the `go/build` bug. So we just do it. Tests use that same path, but can augment the enviroment to set themselves up. In contrast, `gopls` needs to fully specify the environment. It can simply pass in the fully evaluated GO* values. Finally, make the change I was actually here to make: propagate GOMODCACHE and use it where appropriate. Fixes golang/go#39761. Change-Id: I720c69839d91d66d98e94dfc5f065ba0279c5542 Reviewed-on: https://go-review.googlesource.com/c/tools/+/239754 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-06-25 17:33:20 +00:00
..
codelens_test.go	internal/lsp: don't use -modfile for go mod commands	2020-06-22 20:30:43 +00:00
definition_test.go	internal/lsp/regtest: put testing.T back in the test func signature	2020-04-14 18:42:46 +00:00
diagnostics_test.go	all: rework goimports environment, support GOMODCACHE	2020-06-25 17:33:20 +00:00
doc.go	internal/lsp/regtest: add expository package documentation	2020-04-28 21:10:48 +00:00
env_test.go	internal/lsp: instrument work done reporting to use in regtests	2020-04-28 20:46:32 +00:00
env.go	internal/lsp/lsprpc: forward the go environment in initialize requests	2020-06-16 15:43:56 +00:00
formatting_test.go	internal/lsp: fix formatting edge cases (36824)	2020-05-26 20:56:00 +00:00
generate_test.go	internal/lsp/regtest: add support for testing generate commands	2020-05-04 19:25:30 +00:00
imports_test.go	all: rework goimports environment, support GOMODCACHE	2020-06-25 17:33:20 +00:00
link_test.go	internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers	2020-06-18 13:42:42 +00:00
modfile_test.go	all: rework goimports environment, support GOMODCACHE	2020-06-25 17:33:20 +00:00
reg_test.go	internal/lsp/regtest: print RPC logs when verbose output is enabled	2020-06-11 19:16:16 +00:00
runner.go	internal/lsp/lsprpc: forward the go environment in initialize requests	2020-06-16 15:43:56 +00:00
shared_test.go	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
symbol_helper_test.go	internal/lsp/fake: define Symbol method on Editor	2020-05-11 20:27:07 +00:00
symbol_test.go	internal/lsp/fake: define Symbol method on Editor	2020-05-11 20:27:07 +00:00
unix_test.go	internal/lsp/regtest: add a t.Skip for golang/go#36824 regtest	2020-05-21 15:57:04 +00:00
vendor_test.go	internal/lsp: support go mod vendor as a command	2020-06-04 18:33:45 +00:00
wrappers.go	internal/lsp: use -modfile for import organization	2020-06-19 17:44:56 +00:00