Heschi Kreinick e31c80b82c all: rework goimports environment, support GOMODCACHE ... This CL got away from me a little. For a number of reasons, the existing goimports API of passing in values for various GO* values was not working. For one, the number of necessary variables kept growing. For another, we tried to avoid calling `go env` in GOPATH mode by using `build.Default`, but that turns out to be buggy; see golang/go#39838. And finally, it created massive confusion about whether the values were intended to be read from the OS environment, or fully evaluated by the `go` command. There are only two users of the internal imports API, so there really shouldn't need to be more than two modes. For the command line tool, we have to call `go env` to deal with the `go/build` bug. So we just do it. Tests use that same path, but can augment the enviroment to set themselves up. In contrast, `gopls` needs to fully specify the environment. It can simply pass in the fully evaluated GO* values. Finally, make the change I was actually here to make: propagate GOMODCACHE and use it where appropriate. Fixes golang/go#39761. Change-Id: I720c69839d91d66d98e94dfc5f065ba0279c5542 Reviewed-on: https://go-review.googlesource.com/c/tools/+/239754 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-06-25 17:33:20 +00:00
..
analysis.go	internal/memoize: add an error return to (*handle).Get	2020-06-24 16:33:19 +00:00
cache.go	internal/memoize: add an error return to (*handle).Get	2020-06-24 16:33:19 +00:00
check.go	internal/memoize: add an error return to (*handle).Get	2020-06-24 16:33:19 +00:00
error_test.go	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
errors.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
keys.go	internal/lsp: decouple client and server debug	2020-06-11 13:49:48 +00:00
load.go	internal/lsp: use -modfile for import organization	2020-06-19 17:44:56 +00:00
mod_tidy.go	internal/memoize: add an error return to (*handle).Get	2020-06-24 16:33:19 +00:00
mod.go	internal/memoize: add an error return to (*handle).Get	2020-06-24 16:33:19 +00:00
os_darwin.go	internal/lsp: add a mutex around the view's options	2020-04-02 16:41:49 +00:00
os_windows.go	internal/lsp/cache: validate workspace path case	2020-03-27 19:55:53 +00:00
parse.go	internal/memoize: add an error return to (*handle).Get	2020-06-24 16:33:19 +00:00
pkg.go	internal/lsp: read files eagerly	2020-06-11 22:11:59 +00:00
session.go	internal/lsp: refactor various module-specific handles in cache	2020-06-23 18:31:46 +00:00
snapshot.go	internal/lsp: refactor various module-specific handles in cache	2020-06-23 18:31:46 +00:00
view_test.go	internal/lsp/cache: validate workspace path case	2020-03-27 19:55:53 +00:00
view.go	all: rework goimports environment, support GOMODCACHE	2020-06-25 17:33:20 +00:00