1
0
mirror of https://github.com/golang/go synced 2024-11-18 16:04:44 -07:00
go/internal/lsp/source
Rebecca Stambler e31b568ad1 internal/lsp: plumb fillstruct through analysis
Now that fillstruct is an analyzer, we can simplify the code that calls
it in code_action.go. We introduce a new class of analyzer --
convenience analyzers, which are closer to commands. These represent
suggestions that won't necessarily improve the quality or correctness of
your code, but they offer small helper functions for the user.

This CL also combines the refactor rewrite tests with the suggested fix
tests, since they are effectively the same.

For now, we only support convenience analyzers when a code action was
requested on the same line as the fix. I'm not sure how to otherwise
handle this without bothering the user with unnecessary diagnostics.

Change-Id: I7f0aa198b5ee9964a907d709bae6380093d4ef21
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237687
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-06-15 21:22:08 +00:00
..
code_lens.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
completion_builtin.go internal/lsp: remove Ignore feature 2020-06-11 22:55:14 +00:00
completion_format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
completion_keywords.go internal/lsp/source: offer loop keyword completions in range stmt 2020-03-12 04:57:24 +00:00
completion_labels.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
completion_literal.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
completion_snippet.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion_statements.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
deep_completion.go internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
diagnostics.go internal/lsp: plumb fillstruct through analysis 2020-06-15 21:22:08 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format_test.go internal/lsp: fix new bug duplicating comments after includes 2020-05-19 20:57:26 +00:00
format.go internal/lsp: cancel the initial workspace load when view shuts down 2020-06-12 18:06:40 +00:00
highlight.go internal/lsp/source: support labeled statements when highlighting loops 2020-06-10 05:20:24 +00:00
hover.go internal/lsp: fix docs on hover for var/const blocks 2020-05-18 19:53:06 +00:00
identifier.go internal/lsp: remove Ignore feature 2020-06-11 22:55:14 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
options.go internal/lsp: plumb fillstruct through analysis 2020-06-15 21:22:08 +00:00
references.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
rename_check.go internal/lsp/source: remove unused parameters from functions 2020-03-27 18:57:18 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
signature_help.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
source_test.go internal/lsp: plumb fillstruct through analysis 2020-06-15 21:22:08 +00:00
symbols.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
types_format.go internal/lsp: remove Ignore feature 2020-06-11 22:55:14 +00:00
util.go internal/lsp: remove Ignore feature 2020-06-11 22:55:14 +00:00
view.go internal/lsp: await the initial workspace load in ModHandle 2020-06-12 18:21:55 +00:00
workspace_symbol.go internal/lsp: add config option for SymbolMatch 2020-05-11 19:58:58 +00:00