mirror of
https://github.com/golang/go
synced 2024-10-07 09:11:21 -06:00
6e9b1a78ff
Previously Request and Response had redundant fields for Referer, UserAgent, and cookies which caused confusion and bugs. It also didn't allow us to expand the package over time, since the way to access fields would be in the Headers one day and promoted to a field the next day. That would be hard to gofix, especially with code ranging over Headers. After a discussion on the mail package's design with a similar problem, we've designed to make the Headers be the source of truth and add accessors instead. Request: change: Referer -> Referer() change: UserAgent -> UserAgent() change: Cookie -> Cookies() new: Cookie(name) *Cookie new: AddCookie(*Cookie) Response: change: Cookie -> Cookies() Cookie: new: String() string R=rsc CC=golang-dev https://golang.org/cl/4620049
130 lines
3.1 KiB
Go
130 lines
3.1 KiB
Go
// Copyright 2010 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package http
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"fmt"
|
|
"io"
|
|
"testing"
|
|
)
|
|
|
|
type reqTest struct {
|
|
Raw string
|
|
Req Request
|
|
Body string
|
|
}
|
|
|
|
var reqTests = []reqTest{
|
|
// Baseline test; All Request fields included for template use
|
|
{
|
|
"GET http://www.techcrunch.com/ HTTP/1.1\r\n" +
|
|
"Host: www.techcrunch.com\r\n" +
|
|
"User-Agent: Fake\r\n" +
|
|
"Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8\r\n" +
|
|
"Accept-Language: en-us,en;q=0.5\r\n" +
|
|
"Accept-Encoding: gzip,deflate\r\n" +
|
|
"Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7\r\n" +
|
|
"Keep-Alive: 300\r\n" +
|
|
"Content-Length: 7\r\n" +
|
|
"Proxy-Connection: keep-alive\r\n\r\n" +
|
|
"abcdef\n???",
|
|
|
|
Request{
|
|
Method: "GET",
|
|
RawURL: "http://www.techcrunch.com/",
|
|
URL: &URL{
|
|
Raw: "http://www.techcrunch.com/",
|
|
Scheme: "http",
|
|
RawPath: "/",
|
|
RawAuthority: "www.techcrunch.com",
|
|
RawUserinfo: "",
|
|
Host: "www.techcrunch.com",
|
|
Path: "/",
|
|
RawQuery: "",
|
|
Fragment: "",
|
|
},
|
|
Proto: "HTTP/1.1",
|
|
ProtoMajor: 1,
|
|
ProtoMinor: 1,
|
|
Header: Header{
|
|
"Accept": {"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8"},
|
|
"Accept-Language": {"en-us,en;q=0.5"},
|
|
"Accept-Encoding": {"gzip,deflate"},
|
|
"Accept-Charset": {"ISO-8859-1,utf-8;q=0.7,*;q=0.7"},
|
|
"Keep-Alive": {"300"},
|
|
"Proxy-Connection": {"keep-alive"},
|
|
"Content-Length": {"7"},
|
|
"User-Agent": {"Fake"},
|
|
},
|
|
Close: false,
|
|
ContentLength: 7,
|
|
Host: "www.techcrunch.com",
|
|
Form: Values{},
|
|
},
|
|
|
|
"abcdef\n",
|
|
},
|
|
|
|
// Tests that we don't parse a path that looks like a
|
|
// scheme-relative URI as a scheme-relative URI.
|
|
{
|
|
"GET //user@host/is/actually/a/path/ HTTP/1.1\r\n" +
|
|
"Host: test\r\n\r\n",
|
|
|
|
Request{
|
|
Method: "GET",
|
|
RawURL: "//user@host/is/actually/a/path/",
|
|
URL: &URL{
|
|
Raw: "//user@host/is/actually/a/path/",
|
|
Scheme: "",
|
|
RawPath: "//user@host/is/actually/a/path/",
|
|
RawAuthority: "",
|
|
RawUserinfo: "",
|
|
Host: "",
|
|
Path: "//user@host/is/actually/a/path/",
|
|
RawQuery: "",
|
|
Fragment: "",
|
|
},
|
|
Proto: "HTTP/1.1",
|
|
ProtoMajor: 1,
|
|
ProtoMinor: 1,
|
|
Header: Header{},
|
|
Close: false,
|
|
ContentLength: -1,
|
|
Host: "test",
|
|
Form: Values{},
|
|
},
|
|
|
|
"",
|
|
},
|
|
}
|
|
|
|
func TestReadRequest(t *testing.T) {
|
|
for i := range reqTests {
|
|
tt := &reqTests[i]
|
|
var braw bytes.Buffer
|
|
braw.WriteString(tt.Raw)
|
|
req, err := ReadRequest(bufio.NewReader(&braw))
|
|
if err != nil {
|
|
t.Errorf("#%d: %s", i, err)
|
|
continue
|
|
}
|
|
rbody := req.Body
|
|
req.Body = nil
|
|
diff(t, fmt.Sprintf("#%d Request", i), req, &tt.Req)
|
|
var bout bytes.Buffer
|
|
if rbody != nil {
|
|
io.Copy(&bout, rbody)
|
|
rbody.Close()
|
|
}
|
|
body := bout.String()
|
|
if body != tt.Body {
|
|
t.Errorf("#%d: Body = %q want %q", i, body, tt.Body)
|
|
}
|
|
}
|
|
}
|