1
0
mirror of https://github.com/golang/go synced 2024-11-13 18:40:22 -07:00
go/src
Daniel S Fava df68e01b68 runtime: check channel's elemsize before calling race detector
When c.elemsize==0 we call raceacquire() and racerelease()
as opposed to calling racereleaseacquire()

The reason for this change is that, when elemsize==0, we don't
allocate a full buffer for the channel.  Instead of individual
buffer entries, the race detector uses the c.buf as the only
buffer entry.  This simplification prevents us following the
memory model's happens-before rules implemented in racereleaseacquire().
So, instead of calling racereleaseacquire(), we accumulate
happens-before information in the synchronization object associated
with c.buf.

The functionality in this change is implemented in a new function
called racenotify()

Fixes #42598

Change-Id: I75b92708633fdfde658dc52e06264e2171824e51
Reviewed-on: https://go-review.googlesource.com/c/go/+/271987
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Dmitry Vyukov <dvyukov@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Ian Lance Taylor <iant@golang.org>
2020-11-25 15:59:35 +00:00
..
archive archive/zip: fix documentation to mention fs.FS interface 2020-11-07 03:52:47 +00:00
bufio
builtin
bytes bytes: add example for (*Buffer).Bytes 2020-11-11 20:51:00 +00:00
cmd cmd/link: add relocation type R_AARCH64_LDST16_ABS_LO12_NC for arm64 2020-11-25 02:51:30 +00:00
compress
container
context
crypto crypto/tls: de-prioritize AES-GCM ciphers when lacking hardware support 2020-11-10 01:40:27 +00:00
database/sql database/sql, runtime: correct *.Fatal inside goroutines in tests 2020-10-31 20:30:19 +00:00
debug
embed
encoding encoding/asn1: optimize asn1.Unmarshal 2020-11-09 21:36:24 +00:00
errors
expvar
flag
fmt
go go/constant: MakeFloat64(0) must return a value of Float kind 2020-11-25 04:48:23 +00:00
hash
html
image
index/suffixarray
internal net, internal/poll: reset value before adding in minor kernel version 2020-11-20 04:21:00 +00:00
io io/fs: make WalkDirFunc parameter name consistent with doc comment 2020-11-19 21:51:34 +00:00
log
math math/big: fix shift for recursive division 2020-11-12 20:42:40 +00:00
mime
net net, internal/poll: reset value before adding in minor kernel version 2020-11-20 04:21:00 +00:00
os os: gofmt 2020-11-12 10:22:50 +00:00
path io/fs: add WalkDir 2020-11-06 19:42:05 +00:00
plugin
reflect reflect: update NumMethod doc for interface type 2020-11-03 00:50:57 +00:00
regexp regexp/syntax: add note about Unicode character classes 2020-11-25 15:10:09 +00:00
runtime runtime: check channel's elemsize before calling race detector 2020-11-25 15:59:35 +00:00
sort
strconv strconv: revert ParseFloat/ParseComplex error on incorrect bitSize 2020-11-03 23:05:51 +00:00
strings
sync sync: use 386 instead of x86-32 to refer to the 32 bit x86 architecture 2020-11-23 05:57:35 +00:00
syscall syscall: add DLLError.Unwrap function 2020-11-21 07:37:02 +00:00
testdata
testing testing: reduce memory allocation in Helper 2020-11-11 20:48:31 +00:00
text
time time: in NewTicker, document that the 1st tick comes after d 2020-11-18 04:43:50 +00:00
unicode
unsafe
vendor all: update vendored dependencies for Go 1.16 release 2020-11-11 06:26:05 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies for Go 1.16 release 2020-11-11 06:26:05 +00:00
go.sum all: update vendored dependencies for Go 1.16 release 2020-11-11 06:26:05 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash race.bash: add darwin/arm64 2020-11-04 21:02:29 +00:00
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.