1
0
mirror of https://github.com/golang/go synced 2024-11-18 14:24:44 -07:00
go/src
Jonathan Amsterdam deb8e29000 log/slog: JSONHandler elides empty groups even with replacement
Previously, the built-in handlers assumed a group was empty if and
only if it had no attributes. But a ReplaceAttr function that
returned an empty Attr could produce an empty group even if the group
had attrs prior to replacement.

The obvious solution, doing the replacement first and then checking,
would require allocating storage to hold the replaced Attrs.  Instead,
we write to the buffer, and if no attributes were written, we back up
to before the group name.

Fixes #62512.

Change-Id: I140e0901f4b157e36594d8d476f1ab326f8f2c2a
Reviewed-on: https://go-review.googlesource.com/c/go/+/529855
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-10-02 13:57:53 +00:00
..
archive all: use the indefinite article an in comments 2023-09-25 14:29:30 +00:00
arena
bufio all: clean unnecessary casts for test files 2023-09-22 16:22:42 +00:00
builtin
bytes
cmd internal,cmd/internal: relocate covcmd package from std to cmd 2023-09-30 16:13:15 +00:00
cmp cmp: gofmt 2023-09-28 17:57:40 +00:00
compress
container
context all: stop using fmt.Sprintf in t.Error/t.Fatal 2023-09-20 18:57:24 +00:00
crypto all: use the indefinite article an in comments 2023-09-27 01:16:19 +00:00
database/sql all: simplify bool conditions 2023-09-20 18:06:13 +00:00
debug all: clean unnecessary casts for test files 2023-09-22 16:22:42 +00:00
embed
encoding all: use the indefinite article an in comments 2023-09-27 01:16:19 +00:00
errors
expvar
flag
fmt fmt: clarify that we don't call String for %#v 2023-09-25 14:28:27 +00:00
go internal,cmd/internal: relocate covcmd package from std to cmd 2023-09-30 16:13:15 +00:00
hash
html
image all: use the indefinite article an in comments 2023-09-25 14:29:30 +00:00
index/suffixarray all: clean unnecessary casts 2023-09-18 20:01:34 +00:00
internal internal,cmd/internal: relocate covcmd package from std to cmd 2023-09-30 16:13:15 +00:00
io io/fs, path/filepath, cmd/gofmt: replace statDirEntry with fs.FileInfoToDirEntry 2023-09-12 20:27:28 +00:00
log log/slog: JSONHandler elides empty groups even with replacement 2023-10-02 13:57:53 +00:00
maps
math all: simplify bool conditions 2023-09-20 18:06:13 +00:00
mime
net net: set IsNotFound for unknown services in LookupPort 2023-09-28 13:41:21 +00:00
os all: use the indefinite article an in comments 2023-09-25 14:29:30 +00:00
path path/filepath: reuse os.ReadDir 2023-09-29 09:00:12 +00:00
plugin
reflect reflect: remove broken support for embedding of interfaces from StructOf. 2023-09-22 16:25:10 +00:00
regexp regexp: use built-in clear to clear b.visited in *bitState.reset 2023-09-14 17:25:39 +00:00
runtime runtime: reword the documentation for Pinner 2023-09-23 21:06:51 +00:00
slices slices: use strings.EqualFold in ExampleCompactFunc 2023-09-22 21:08:15 +00:00
sort
strconv
strings
sync
syscall syscall: make origRlimitNofile atomic.Pointer[Rlimit] 2023-09-29 18:51:35 +00:00
testdata
testing testing: use strings.LastIndexAny in (*common).decorate 2023-09-13 18:06:09 +00:00
text
time all: clean unnecessary casts for test files 2023-09-22 16:22:42 +00:00
unicode
unsafe
vendor cmd: go get golang.org/x/tools@f9b8da7 and revendor 2023-09-21 21:08:44 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod cmd: go get golang.org/x/tools@f9b8da7 and revendor 2023-09-21 21:08:44 +00:00
go.sum cmd: go get golang.org/x/tools@f9b8da7 and revendor 2023-09-21 21:08:44 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.