mirror of
https://github.com/golang/go
synced 2024-11-14 14:50:23 -07:00
b92a0a8969
In https://golang.org/cl/7797 I attempted to use myimportpath to set the value of the go.importpath.$foo. symbol for the module being compiled, but I messed it up and only set the name (which the linker rewrites anyway). This lead to the importpath for the module being compiled being "". This was hard to notice, because all modules that import another define the importpath for their imported modules correctly -- but main is not imported, and this meant that the reflect module saw all fields of all types defined in the main module as exported. The fix is to do what I meant to do the first time, add a test and change the go tool to compile main packages with -p main and not -p command-line-arguments. Fixes #10332 Change-Id: I5fc6e9b1dc2b26f058641e382f9a56a526eca291 Reviewed-on: https://go-review.googlesource.com/8481 Reviewed-by: Russ Cox <rsc@golang.org>
26 lines
486 B
Go
26 lines
486 B
Go
// run
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// The PkgPath of unexported fields of types defined in package main was incorrectly ""
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
)
|
|
|
|
type foo struct {
|
|
bar int
|
|
}
|
|
|
|
func main() {
|
|
pkgpath := reflect.ValueOf(foo{}).Type().Field(0).PkgPath
|
|
if pkgpath != "main" {
|
|
fmt.Printf("BUG: incorrect PkgPath: %v", pkgpath)
|
|
}
|
|
}
|