mirror of
https://github.com/golang/go
synced 2024-11-23 09:50:03 -07:00
e99e9a6e01
The compiler renames anonymous and blank result parameters to ~rN or ~bN, but the current semantics for computing N are rather annoying and difficult to reproduce cleanly. They also lead to difficult to read escape analysis results in tests. This CL changes N to always be calculated as the parameter's index within the function's result parameter tuple. E.g., if a function has a single result, it will now always be named "~r0". The normative change to this CL is fairly simple, but it requires updating a lot of test expectations. Change-Id: I58a3c94de00cb822cb94efe52d115531193c993c Reviewed-on: https://go-review.googlesource.com/c/go/+/323010 Trust: Matthew Dempsky <mdempsky@google.com> Trust: Dan Scales <danscales@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dan Scales <danscales@google.com>
89 lines
1.5 KiB
Go
89 lines
1.5 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Tests escape analysis for range of arrays.
|
|
// Compiles but need not run. Inlining is disabled.
|
|
|
|
package main
|
|
|
|
type A struct {
|
|
b [3]uint64
|
|
}
|
|
|
|
type B struct {
|
|
b [3]*uint64
|
|
}
|
|
|
|
func f(a A) int {
|
|
for i, x := range &a.b {
|
|
if x != 0 {
|
|
return 64*i + int(x)
|
|
}
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func g(a *A) int { // ERROR "a does not escape"
|
|
for i, x := range &a.b {
|
|
if x != 0 {
|
|
return 64*i + int(x)
|
|
}
|
|
}
|
|
return 0
|
|
}
|
|
|
|
func h(a *B) *uint64 { // ERROR "leaking param: a to result ~r0 level=1"
|
|
for i, x := range &a.b {
|
|
if i == 0 {
|
|
return x
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func h2(a *B) *uint64 { // ERROR "leaking param: a to result ~r0 level=1"
|
|
p := &a.b
|
|
for i, x := range p {
|
|
if i == 0 {
|
|
return x
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Seems like below should be level=1, not 0.
|
|
func k(a B) *uint64 { // ERROR "leaking param: a to result ~r0 level=0"
|
|
for i, x := range &a.b {
|
|
if i == 0 {
|
|
return x
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
var sink *uint64
|
|
|
|
func main() {
|
|
var a1, a2 A
|
|
var b1, b2, b3, b4 B
|
|
var x1, x2, x3, x4 uint64 // ERROR "moved to heap: x1" "moved to heap: x3"
|
|
b1.b[0] = &x1
|
|
b2.b[0] = &x2
|
|
b3.b[0] = &x3
|
|
b4.b[0] = &x4
|
|
f(a1)
|
|
g(&a2)
|
|
sink = h(&b1)
|
|
h(&b2)
|
|
sink = h2(&b1)
|
|
h2(&b4)
|
|
x1 = 17
|
|
println("*sink=", *sink) // Verify that sink addresses x1
|
|
x3 = 42
|
|
sink = k(b3)
|
|
println("*sink=", *sink) // Verify that sink addresses x3
|
|
}
|