1
0
mirror of https://github.com/golang/go synced 2024-11-18 20:04:52 -07:00
go/internal/lsp/source
Iskander Sharipov dbc83e6dc0 internal/lsp/source: fix typeIsValid() inf recursion
typeIsValid() intended to stop on a named type, but
since we called Underlying(), switch case never caught any
named type. To avoid that, do an early check.

Fixes golang/go#36637

Change-Id: I2700afbb8f9678b4542e2e7dccc3be59b1d9ebdf
Reviewed-on: https://go-review.googlesource.com/c/tools/+/215238
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-21 04:27:40 +00:00
..
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
completion_builtin.go internal/lsp/cache: initialize view before LookupBuiltin 2020-01-16 00:42:58 +00:00
completion_format.go internal/lsp/source: improve completion in type assertions 2020-01-16 01:06:23 +00:00
completion_keywords.go internal/lsp: sort by label after score 2019-12-30 21:11:21 +00:00
completion_labels.go internal/lsp: sort by label after score 2019-12-30 21:11:21 +00:00
completion_literal.go internal/lsp/source: improve completion in type assertions 2020-01-16 01:06:23 +00:00
completion_snippet.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion.go internal/lsp/source: fix ranking of untyped completions 2020-01-17 21:50:04 +00:00
deep_completion.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
diagnostics.go internal/lsp: diagnose the snapshot on every text synchronization event 2020-01-15 23:07:48 +00:00
errors.go internal/lsp: do not invoke the Go command when checking common errors 2020-01-17 21:23:25 +00:00
folding_range.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
format_test.go internal/lsp/source: trim file very carefully 2020-01-17 20:34:13 +00:00
format.go internal/lsp/source: trim file very carefully 2020-01-17 20:34:13 +00:00
highlight.go internal/lsp: add highlighting for import statement 2020-01-17 17:07:20 +00:00
hover.go internal/lsp: show comments for grouped variable declarations 2019-12-18 20:39:36 +00:00
identifier.go internal/lsp: refactor find-references and rename 2020-01-16 06:24:15 +00:00
implementation.go internal/lsp: refactor find-references and rename 2020-01-16 06:24:15 +00:00
options.go internal/lsp/source: enable unimported completions by default 2020-01-17 22:05:05 +00:00
references.go internal/lsp/source: return obj decl first in find-references 2020-01-16 16:57:51 +00:00
rename_check.go internal/lsp: improve literal func completion candidates 2019-11-07 21:18:00 +00:00
rename.go internal/lsp: refactor find-references and rename 2020-01-16 06:24:15 +00:00
signature_help.go internal/lsp/cache: initialize view before LookupBuiltin 2020-01-16 00:42:58 +00:00
source_test.go internal/lsp/source: enable unimported completions by default 2020-01-17 22:05:05 +00:00
symbols.go internal/lsp/source: always look up mapper when building ranges 2020-01-16 01:10:02 +00:00
util.go internal/lsp/source: fix typeIsValid() inf recursion 2020-01-21 04:27:40 +00:00
view.go internal/lsp: do not invoke the Go command when checking common errors 2020-01-17 21:23:25 +00:00