1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:04:46 -07:00
go/internal/lsp/lsprpc
Rob Findley b8469989bc internal/lsp/fake: fix some messiness around client hooks
While writing the fake editor, I added some state tracking without using
it (log messages, events etc). We have since duplicated this logic in
the regtest package using client hooks.

Fix two messy aspects of this:
 - remove the state tracking in the editor
 - pass in the client hooks when connecting, so that they may be used
   without locking, and so that we do not miss any hooks that may fire
   during session initialization.

Change-Id: I24c17a28e9cfa4fca32b7ddd17c7bf01cbb12e0f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/232744
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-05-08 18:47:54 +00:00
..
autostart_default.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
autostart_posix.go internal/lsp: use %w in error wrappers 2020-05-04 14:52:14 +00:00
lsprpc_test.go internal/lsp/fake: fix some messiness around client hooks 2020-05-08 18:47:54 +00:00
lsprpc.go internal/lsp: fix incorrect format strings when calling event.Error 2020-05-04 19:35:31 +00:00