mirror of
https://github.com/golang/go
synced 2024-11-17 21:14:44 -07:00
8893175c3b
A few of the tests were printing garbage to stderr, since FlagSet's default Output is os.Stderr: $ go test flag provided but not defined: -x invalid value "1" for flag -v: test error Usage of test: flag needs an argument: -b Usage of test: -b usage PASS ok flag 0.008s Add the remaining SetOutput(io.Discard) method calls. Note that TestUserDefinedFunc was a tricky one. Even with the added SetOutput calls, the last part of the test would still print usage text to stderr. It took me a while to figure out the problem was copying FlagSet. I've filed go.dev/issue/51507 to record this particular sharp edge, and the test code now avoids making FlagSet copies to avoid the bug. Change-Id: I323f24091b98386312aa72df3eb890af6625628d Reviewed-on: https://go-review.googlesource.com/c/go/+/390234 Trust: Daniel Martí <mvdan@mvdan.cc> Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
25 lines
653 B
Go
25 lines
653 B
Go
// Copyright 2010 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package flag
|
|
|
|
import (
|
|
"io"
|
|
"os"
|
|
)
|
|
|
|
// Additional routines compiled into the package only during testing.
|
|
|
|
var DefaultUsage = Usage
|
|
|
|
// ResetForTesting clears all flag state and sets the usage function as directed.
|
|
// After calling ResetForTesting, parse errors in flag handling will not
|
|
// exit the program.
|
|
func ResetForTesting(usage func()) {
|
|
CommandLine = NewFlagSet(os.Args[0], ContinueOnError)
|
|
CommandLine.SetOutput(io.Discard)
|
|
CommandLine.Usage = commandLineUsage
|
|
Usage = usage
|
|
}
|