mirror of
https://github.com/golang/go
synced 2024-11-27 00:51:26 -07:00
90a8482a17
I made the default be that, where there are differences between types2 and -G=0 error messages, we want errorcheck tests to pass types2. Typically, we can get errorcheck to pass on types2 and -G=0 if they give the same number of error messages on the same lines, just different wording. If they give a different number of error messages, then I made types2 pass. I added an exception list for -G=0 to cover those cases where -G=0 and types give different numbers of error messages. Because types2 does not run if there are syntax errors, for several tests, I had to split the tests into two parts in order to get all the indicated errors to be reported in types2 (bug228.go, bug388.go, issue11610.go, issue14520.go) I tried to preserve the GCCGO labeling correctly (but may have gotten some wrong). When types2 now matches where a GCCGO error previously occurred, I transformed GCCGO_ERROR -> ERROR. When types2 no longer reports an error in a certain place, I transformed ERROR -> GCCGO_ERROR. When types2 reports an error in a new place, I used GC_ERROR. The remaining entries in types2Failures are things that I think we probably still need to fix - either actually missing errors in types2, or cases where types2 gives worse errors than -G=0. Change-Id: I7f01e82b322b16094096b67d7ed2bb39b410c34f Reviewed-on: https://go-review.googlesource.com/c/go/+/372854 Trust: Dan Scales <danscales@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
42 lines
1.1 KiB
Go
42 lines
1.1 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Verify that erroneous initialization expressions are caught by the compiler
|
|
// Does not compile.
|
|
|
|
package main
|
|
|
|
type S struct {
|
|
A, B, C, X, Y, Z int
|
|
}
|
|
|
|
type T struct {
|
|
S
|
|
}
|
|
|
|
var x = 1
|
|
var a1 = S{0, X: 1} // ERROR "mixture|undefined" "too few values"
|
|
var a2 = S{Y: 3, Z: 2, Y: 3} // ERROR "duplicate"
|
|
var a3 = T{S{}, 2, 3, 4, 5, 6} // ERROR "convert|too many"
|
|
var a4 = [5]byte{1, 2, 3, 4, 5, 6, 7, 8, 9, 10} // ERROR "index|too many"
|
|
var a5 = []byte{x: 2} // ERROR "index"
|
|
var a6 = []byte{1: 1, 2: 2, 1: 3} // ERROR "duplicate"
|
|
|
|
var ok1 = S{} // should be ok
|
|
var ok2 = T{S: ok1} // should be ok
|
|
|
|
// These keys can be computed at compile time but they are
|
|
// not constants as defined by the spec, so they do not trigger
|
|
// compile-time errors about duplicate key values.
|
|
// See issue 4555.
|
|
|
|
type Key struct{ X, Y int }
|
|
|
|
var _ = map[Key]string{
|
|
Key{1, 2}: "hello",
|
|
Key{1, 2}: "world",
|
|
}
|