mirror of
https://github.com/golang/go
synced 2024-09-30 12:28:35 -06:00
d96b7fbf98
This CL moves order.go's copyRet logic for rewriting f(g()) into t1, t2, ... = g(); f(t1, t2, ...) earlier into typecheck. This allows the rest of the compiler to stop worrying about multi-value functions appearing outside of OAS2FUNC nodes. This changes compiler behavior in a few observable ways: 1. Typechecking error messages for builtin functions now use general case error messages rather than unnecessarily differing ones. 2. Because f(g()) is rewritten before inlining, saved inline bodies now see the rewritten form too. This could be addressed, but doesn't seem worthwhile. 3. Most notably, this simplifies escape analysis and fixes a memory corruption issue in esc.go. See #29197 for details. Fixes #15992. Fixes #29197. Change-Id: I86a70668301efeec8fbd11fe2d242e359a3ad0af Reviewed-on: https://go-review.googlesource.com/c/153841 Reviewed-by: Robert Griesemer <gri@golang.org>
39 lines
593 B
Go
39 lines
593 B
Go
// run
|
|
|
|
// Copyright 2018 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
)
|
|
|
|
func f(a []byte) ([]byte, []byte) {
|
|
return a, []byte("abc")
|
|
}
|
|
|
|
func g(a []byte) ([]byte, string) {
|
|
return a, "abc"
|
|
}
|
|
|
|
func h(m map[int]int) (map[int]int, int) {
|
|
return m, 0
|
|
}
|
|
|
|
func main() {
|
|
a := []byte{1, 2, 3}
|
|
n := copy(f(a))
|
|
fmt.Println(n, a)
|
|
|
|
b := []byte{1, 2, 3}
|
|
n = copy(f(b))
|
|
fmt.Println(n, b)
|
|
|
|
m := map[int]int{0: 0}
|
|
fmt.Println(len(m))
|
|
delete(h(m))
|
|
fmt.Println(len(m))
|
|
}
|