d73885588a
The global ListOfHotCallSites set is used to communicate between CanInline and InlineCalls the set of call sites that InlineCalls may increase the budget for. CanInline clears this map on each call, thus assuming that InlineCalls(x) is called immediately after CanInline(x). This assumption is false, as CanInline (among other cases) is recursive (CanInline -> hairyVisitor.doNode -> inlCallee -> CanInline). When this assumption proves false, we will lose the opportunity to inline hot calls. This CL is the least invasive fix for this. ListOfHotCallSites is actually just a subset of the candHotEdgeMap, with CallSiteInfo.Callee cleared. candHotEdgeMap doesn't actually need to distinguish based on Callee, so we can drop callee from candHotEdgeMap as well and just use that directly [1]. Later CLs should do more work to remove the globals entirely. For cmd/compile, this inceases the number of PGO inlined functions by ~50% for one set of PGO parameters. I have no evaluated performance impact. [1] This is something that we likely want to change in the future. For #55022. Change-Id: I57735958d651f6dfa9bd296499841213d20e1706 Reviewed-on: https://go-review.googlesource.com/c/go/+/446755 Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.