Rebecca Stambler d7101b74a4 internal/lsp: set version correctly after textDocument/didOpen ... The early return logic for didOpen events in (*snapshot).invalidateContent was preventing the creation of a new snapshot, which was in turn stopping the versions from being updated. This exposed a fundamental issue in the way we were calculating workspace diagnostics. Since we weren't waiting for diagnostics to be completed for an entire snapshot before replying that the server had been initialized, snapshots were being cloned without any type information. For quickfix code actions, we assume that we have all information cached (since we need to have sent the diagnostics that the quickfix is mapped to), so we were not finding the cached analysis results. To handle this in the short-term, we key analyses by their names, and then regenerate results as-needed for code actions. This is technically more correct than simply assuming that we have the analyses cached. In a follow-up CL, I will send a follow-up that will make sure that snapshots "wait" on each other to be fully constructed before being cloned. Change-Id: Ie89fcdb438b6b8b675f87335561bf47b768641ac Reviewed-on: https://go-review.googlesource.com/c/tools/+/208265 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com>		2019-11-25 19:35:51 +00:00
..
browser	internal/lsp: add version and bug commands	2019-05-11 04:16:02 +00:00
cache	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
cmd	internal/lsp: use AST to construct placeholders	2019-11-25 01:11:57 +00:00
debug	internal/lsp: fix the debug info pages	2019-11-04 23:16:26 +00:00
diff	internal/lsp: fix unified diffs of edits at the end of a file	2019-10-11 16:38:14 +00:00
fuzzy	internal/lsp: fix fuzzy matcher inconsistency	2019-10-22 21:05:28 +00:00
protocol	internal/lsp: make Range a pointer in Change events	2019-11-20 19:02:09 +00:00
snippet	all: fix broken links to LSP specification	2019-10-02 18:32:53 +00:00
source	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
telemetry	internal/lsp: call load in (*session).NewView	2019-11-07 23:34:59 +00:00
testdata	internal/lsp: add tests for cgo package users	2019-11-25 19:20:57 +00:00
tests	internal/lsp: delete the source.Diagnostic.File field	2019-11-22 00:05:30 +00:00
code_action.go	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
command.go	internal/lsp: fix panic in bestView	2019-11-16 21:44:31 +00:00
completion_test.go	internal/lsp: fix variadic interface completion ranking	2019-11-18 05:14:29 +00:00
completion.go	internal/lsp: improve completion ordering workaround	2019-11-22 18:27:03 +00:00
definition.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
diagnostics.go	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
folding_range.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
format.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
general.go	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
highlight.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
hover.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
implementation.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
link.go	internal/lsp: fix panic in bestView	2019-11-16 21:44:31 +00:00
lsp_test.go	internal/lsp: use snapshot to get reverse dependencies	2019-11-22 02:13:35 +00:00
references.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
rename.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
reset_golden.sh	internal/lsp: fix regeneration of golden files	2019-09-25 13:16:59 +00:00
server.go	internal/lsp: handle first change behavior on the server side	2019-11-22 18:53:53 +00:00
signature_help.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
symbols.go	internal/lsp: reorganize and refactor code	2019-11-21 02:33:28 +00:00
text_synchronization.go	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
watched_files.go	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00
workspace.go	internal/lsp: set version correctly after textDocument/didOpen	2019-11-25 19:35:51 +00:00