mirror of
https://github.com/golang/go
synced 2024-10-01 08:28:43 -06:00
e77c06808a
Go's CL numbers as assigned by Gerrit have started to collide with the lower numbers in the sparse set of CL numbers as returned by our old code review system (Rietveld). The old heuristic no longer works now that Gerrit CL numbers have reached 150000. Instead, include a map of the low Rietveld CL numbers where we might overlap and bump the threshold heuristic up. Updates golang/go#28836 Change-Id: Ice719ab807ce3922b885a800ac873cdbf165a8f7 Reviewed-on: https://go-review.googlesource.com/c/150057 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
114 lines
3.8 KiB
Go
114 lines
3.8 KiB
Go
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package redirect
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
)
|
|
|
|
type redirectResult struct {
|
|
status int
|
|
path string
|
|
}
|
|
|
|
func errorResult(status int) redirectResult {
|
|
return redirectResult{status, ""}
|
|
}
|
|
|
|
func TestRedirects(t *testing.T) {
|
|
var tests = map[string]redirectResult{
|
|
"/build": {301, "http://build.golang.org"},
|
|
"/ref": {301, "/doc/#references"},
|
|
"/doc/mem": {301, "/ref/mem"},
|
|
"/doc/spec": {301, "/ref/spec"},
|
|
"/tour": {301, "http://tour.golang.org"},
|
|
"/foo": errorResult(404),
|
|
|
|
"/pkg/asn1": {301, "/pkg/encoding/asn1/"},
|
|
"/pkg/template/parse": {301, "/pkg/text/template/parse/"},
|
|
|
|
"/src/pkg/foo": {301, "/src/foo"},
|
|
|
|
"/cmd/gofix": {301, "/cmd/fix/"},
|
|
|
|
// git commits (/change)
|
|
// TODO: mercurial tags and LoadChangeMap.
|
|
"/change": {301, "https://go.googlesource.com/go"},
|
|
"/change/a": {302, "https://go.googlesource.com/go/+/a"},
|
|
|
|
"/issue": {301, "https://github.com/golang/go/issues"},
|
|
"/issue?": {301, "https://github.com/golang/go/issues"},
|
|
"/issue/1": {302, "https://github.com/golang/go/issues/1"},
|
|
"/issue/new": {301, "https://github.com/golang/go/issues/new"},
|
|
"/issue/new?a=b&c=d%20&e=f": {301, "https://github.com/golang/go/issues/new?a=b&c=d%20&e=f"},
|
|
"/issues": {301, "https://github.com/golang/go/issues"},
|
|
"/issues/1": {302, "https://github.com/golang/go/issues/1"},
|
|
"/issues/new": {301, "https://github.com/golang/go/issues/new"},
|
|
"/issues/1/2/3": errorResult(404),
|
|
|
|
"/wiki/foo": {302, "https://github.com/golang/go/wiki/foo"},
|
|
"/wiki/foo/": {302, "https://github.com/golang/go/wiki/foo/"},
|
|
|
|
"/design": {301, "https://go.googlesource.com/proposal/+/master/design"},
|
|
"/design/": {302, "/design"},
|
|
"/design/123-foo": {302, "https://go.googlesource.com/proposal/+/master/design/123-foo.md"},
|
|
"/design/text/123-foo": {302, "https://go.googlesource.com/proposal/+/master/design/text/123-foo.md"},
|
|
|
|
"/cl/1": {302, "https://go-review.googlesource.com/1"},
|
|
"/cl/1/": {302, "https://go-review.googlesource.com/1"},
|
|
"/cl/267120043": {302, "https://codereview.appspot.com/267120043"},
|
|
"/cl/267120043/": {302, "https://codereview.appspot.com/267120043"},
|
|
|
|
// Verify that we're using the Rietveld CL table:
|
|
"/cl/152046": {302, "https://codereview.appspot.com/152046"},
|
|
"/cl/152047": {302, "https://go-review.googlesource.com/152047"},
|
|
"/cl/152048": {302, "https://codereview.appspot.com/152048"},
|
|
|
|
// And verify we're using the the "bigEnoughAssumeRietveld" value:
|
|
"/cl/299999": {302, "https://go-review.googlesource.com/299999"},
|
|
"/cl/300000": {302, "https://codereview.appspot.com/300000"},
|
|
}
|
|
|
|
mux := http.NewServeMux()
|
|
Register(mux)
|
|
ts := httptest.NewServer(mux)
|
|
defer ts.Close()
|
|
|
|
for path, want := range tests {
|
|
if want.path != "" && want.path[0] == '/' {
|
|
// All redirects are absolute.
|
|
want.path = ts.URL + want.path
|
|
}
|
|
|
|
req, err := http.NewRequest("GET", ts.URL+path, nil)
|
|
if err != nil {
|
|
t.Errorf("(path: %q) unexpected error: %v", path, err)
|
|
continue
|
|
}
|
|
|
|
resp, err := http.DefaultTransport.RoundTrip(req)
|
|
if err != nil {
|
|
t.Errorf("(path: %q) unexpected error: %v", path, err)
|
|
continue
|
|
}
|
|
|
|
if resp.StatusCode != want.status {
|
|
t.Errorf("(path: %q) got status %d, want %d", path, resp.StatusCode, want.status)
|
|
}
|
|
|
|
if want.status != 301 && want.status != 302 {
|
|
// Not a redirect. Just check status.
|
|
continue
|
|
}
|
|
|
|
out, _ := resp.Location()
|
|
if got := out.String(); got != want.path {
|
|
t.Errorf("(path: %q) got %s, want %s", path, got, want.path)
|
|
}
|
|
}
|
|
}
|