1
0
mirror of https://github.com/golang/go synced 2024-11-22 10:34:46 -07:00
go/src
Garrett Bodley d61b73c1d1 crypto/aes: Avo port of asm_amd64.s
This implementation utilizes the same registers found in the reference
implementation, aiming to produce a minimal semantic diff between the
Avo-generated output and the original hand-written assembly.

To verify the Avo implementation, the reference and Avo-generated
assembly files are fed to `go tool asm`, capturing the debug output into
corresponding temp files. The debug output contains supplementary
metadata (line numbers, instruction offsets, and source file references)
that must be removed in order to obtain a semantic diff of the two
files. This is accomplished via a small utility script written in awk.

The reference assembly file does not specify a frame size for some of
the defined assembly functions. Avo automatically infers the frame size
when generating TEXT directives, leading to a diff on those lines.

Commands used to verify Avo output:

GOROOT=$(go env GOROOT)
ASM_PATH="src/crypto/aes/asm_amd64.s"
REFERENCE="54fe0fd43fcf8609666c16ae6d15ed92873b1564"

go tool asm -o /dev/null -I "$GOROOT"/src/runtime -debug \
  <(git cat-file -p "$REFERENCE:$ASM_PATH") \
  > /tmp/reference.s

go tool asm -o /dev/null -I "$GOROOT"/src/runtime -debug \
  "$ASM_PATH" \
  > /tmp/avo.s

normalize(){
  awk '{
    $1=$2=$3="";
    print substr($0,4)
  }'
}

diff <(normalize < /tmp/reference.s) <(normalize < /tmp/avo.s)

1c1
< TEXT <unlinkable>.encryptBlockAsm(SB), NOSPLIT, $0
---
> TEXT <unlinkable>.encryptBlockAsm(SB), NOSPLIT, $0-32
45c45
< TEXT <unlinkable>.decryptBlockAsm(SB), NOSPLIT, $0
---
> TEXT <unlinkable>.decryptBlockAsm(SB), NOSPLIT, $0-32
89c89
< TEXT <unlinkable>.expandKeyAsm(SB), NOSPLIT, $0
---
> TEXT <unlinkable>.expandKeyAsm(SB), NOSPLIT, $0-32

Change-Id: If647584df4137146d355f91ac0f6a8285d07c932
Reviewed-on: https://go-review.googlesource.com/c/go/+/600375
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
2024-09-04 20:36:51 +00:00
..
archive archive/zip,cmd/compile: simplify the split function 2024-08-03 01:05:29 +00:00
arena
bufio all: omit unnecessary 0 in slice expression 2024-09-03 20:55:15 +00:00
builtin
bytes all: omit unnecessary 0 in slice expression 2024-09-03 20:55:15 +00:00
cmd crypto/aes: Avo port of asm_amd64.s 2024-09-04 20:36:51 +00:00
cmp
compress src: fix typos 2024-08-20 21:01:59 +00:00
container
context context: document that WithValue returns a derived context 2024-09-03 00:19:35 +00:00
crypto crypto/aes: Avo port of asm_amd64.s 2024-09-04 20:36:51 +00:00
database/sql database/sql: fix panic with concurrent Conn and Close 2024-08-24 00:26:08 +00:00
debug debug/macho: fix DWARF for section names longer than 16 chars 2024-08-30 17:51:51 +00:00
embed crypto/x509,embed: use slices to clean up tests 2024-07-24 16:44:15 +00:00
encoding encoding/xml: allow ]]> in attribute values 2024-09-04 13:33:11 +00:00
errors
expvar
flag flag: handle nil os.Args when setting CommandLine at package level 2024-07-22 20:58:27 +00:00
fmt fmt: remove ineffective else branch in test 2024-08-08 23:21:43 +00:00
go crypto/aes: Avo port of asm_amd64.s 2024-09-04 20:36:51 +00:00
hash crypto,hash: add t.Helper calls to test helpers 2024-08-15 20:19:52 +00:00
html html/template: track continue nodes correctly when escaping 2024-08-27 17:55:55 +00:00
image image: use Rectangle{} instead of ZR 2024-09-01 15:47:54 +00:00
index/suffixarray
internal internal/weak: shade pointer in weak-to-strong conversion 2024-09-04 18:13:24 +00:00
io all: use t.Chdir in tests 2024-09-04 00:52:28 +00:00
iter
log log/slog: implement encoding.TextAppender for Level and LevelVar 2024-08-14 14:45:28 +00:00
maps maps, slices: fix variable name and comment in example 2024-08-14 18:28:34 +00:00
math math: add large exact float rounding tests 2024-09-04 13:36:10 +00:00
mime mime: add available godoc link 2024-08-03 01:05:26 +00:00
net all: omit unnecessary 0 in slice expression 2024-09-03 20:55:15 +00:00
os os/user: User.GroupIds shouldn't error on users with no groups 2024-09-04 04:56:53 +00:00
path all: use t.Chdir in tests 2024-09-04 00:52:28 +00:00
plugin plugin: include a warning about race detector compatability in docs 2024-08-09 19:50:41 +00:00
reflect cmd/compile,runtime: disable swissmap fast variants 2024-08-02 16:47:38 +00:00
regexp all: omit unnecessary 0 in slice expression 2024-09-03 20:55:15 +00:00
runtime internal/weak: shade pointer in weak-to-strong conversion 2024-09-04 18:13:24 +00:00
slices all: omit unnecessary 0 in slice expression 2024-09-03 20:55:15 +00:00
sort sort: drop implementation for Go <1.21 2024-08-21 21:18:47 +00:00
strconv strconv: document that Unquote("''") returns an empty string 2024-07-22 18:35:09 +00:00
strings all: remove duplicated words in comments 2024-08-19 19:09:04 +00:00
structs
sync all: make struct comments match struct names 2024-07-11 17:23:45 +00:00
syscall all: use t.Chdir in tests 2024-09-04 00:52:28 +00:00
testdata
testing testing: use testenv.Executable 2024-09-03 18:03:28 +00:00
text text/template: fix doc spacing 2024-07-22 20:58:50 +00:00
time all: omit unnecessary 0 in slice expression 2024-09-03 20:55:15 +00:00
unicode all: omit unnecessary 0 in slice expression 2024-09-03 20:55:15 +00:00
unique unique: don't retain uncloned input as key 2024-09-04 18:13:29 +00:00
unsafe unsafe: say "functions like syscall.Syscall", not only Syscall 2024-07-11 23:38:31 +00:00
vendor all: update golang.org/x/sys to v0.23.0 2024-08-07 19:37:23 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update golang.org/x/sys to v0.23.0 2024-08-07 19:37:23 +00:00
go.sum all: update golang.org/x/sys to v0.23.0 2024-08-07 19:37:23 +00:00
make.bash cmd/dist: require Go 1.22.6 as minimum bootstrap toolchain 2024-08-20 17:52:42 +00:00
make.bat cmd/dist: require Go 1.22.6 as minimum bootstrap toolchain 2024-08-20 17:52:42 +00:00
Make.dist
make.rc cmd/dist: require Go 1.22.6 as minimum bootstrap toolchain 2024-08-20 17:52:42 +00:00
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.