1
0
mirror of https://github.com/golang/go synced 2024-11-18 18:44:42 -07:00
go/internal/lsp/regtest
Rebecca Stambler f53864d0db internal/lsp: remove command-line-arguments as a workspace package
If a package starts out as command-line-arguments, and then becomes
"valid" (i.e., gets a package declaration), we shouldn't continue to try
to diagnose "command-line-arguments". We should remove
"command-line-arguments" from workspace packages any time its metadata
is invalidated (assuming it may get added back if a file= query produces
it again).

Include the relevant regression test.

Fixes golang/go#37978

Change-Id: I7fc51edeb58007b4b4a163336cbeb752a53da322
Reviewed-on: https://go-review.googlesource.com/c/tools/+/225317
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-25 20:31:30 +00:00
..
definition_test.go internal/lsp/regtest: remove redundant T and ctx params from regtest funcs 2020-03-24 20:18:24 +00:00
diagnostics_test.go internal/lsp: remove command-line-arguments as a workspace package 2020-03-25 20:31:30 +00:00
env.go internal/lsp/regtest: remove redundant T and ctx params from regtest funcs 2020-03-24 20:18:24 +00:00
formatting_test.go internal/lsp/regtest: remove redundant T and ctx params from regtest funcs 2020-03-24 20:18:24 +00:00
reg_test.go internal/lsp/regtest: clean-up and more error handling 2020-02-25 19:00:36 +00:00
serialization_test.go internal/lsp/regtest: remove redundant T and ctx params from regtest funcs 2020-03-24 20:18:24 +00:00
shared_test.go internal/lsp/regtest: remove redundant T and ctx params from regtest funcs 2020-03-24 20:18:24 +00:00
wrappers.go internal/lsp: remove command-line-arguments as a workspace package 2020-03-25 20:31:30 +00:00