1
0
mirror of https://github.com/golang/go synced 2024-11-17 02:34:46 -07:00
go/src
Mitar d463de61b3 net/http: remove misleading response headers on error
ServeContent API is to set some headers you want to see in the response
before calling ServeContent. But if there is an error, those headers
should be removed otherwise they might confused the client.

Removing those headers is useful in general in the case of an error,
so we remove them in http.Error.

Fixes #50905.

Change-Id: If8d2786c1512906ac93e6b388df6ab1c5ecd1ea9
GitHub-Last-Rev: 32b6f045a7
GitHub-Pull-Request: golang/go#64312
Reviewed-on: https://go-review.googlesource.com/c/go/+/544019
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
2024-03-06 19:15:50 +00:00
..
archive
arena
bufio
builtin
bytes bytes: add a colon after Output to make the Example in the document display correctly 2024-03-04 15:54:40 +00:00
cmd cmd/dist: fix typo in comment 2024-03-06 19:14:39 +00:00
cmp
compress
container
context
crypto crypto/x509: make sure pub key is non-nil before interface conversion 2024-03-05 18:28:56 +00:00
database/sql database/sql: remove useless error check 2024-03-06 19:14:36 +00:00
debug
embed
encoding encoding/json: make use of reflect.Type.{OverflowInt, OverflowUint} 2024-02-29 18:45:05 +00:00
errors
expvar
flag
fmt fmt: allow padding and minus flags at the same time 2024-03-04 17:31:55 +00:00
go go/types, types2: consistently use error_ type for sub-errors (cleanup) 2024-02-29 22:06:18 +00:00
hash
html
image
index/suffixarray
internal internal/trace: remove unreachable code 2024-03-06 16:24:06 +00:00
io
iter
log
maps all: run go fmt 2024-02-28 20:35:05 +00:00
math math/rand, math/rand/v2: rename receiver variables 2024-03-04 17:32:49 +00:00
mime net/textproto, mime/multipart: avoid unbounded read in MIME header 2024-03-05 18:31:56 +00:00
net net/http: remove misleading response headers on error 2024-03-06 19:15:50 +00:00
os os: fix 63703.md release notes 2024-03-05 16:20:15 +00:00
path os: don't normalize volumes to drive letters in os.Readlink 2024-03-04 20:38:54 +00:00
plugin
reflect runtime: use .Pointers() instead of manual checking 2024-03-04 17:34:30 +00:00
regexp
runtime os: don't normalize volumes to drive letters in os.Readlink 2024-03-04 20:38:54 +00:00
slices slices: document that Clone can return extra capacity 2024-03-05 20:52:30 +00:00
sort
strconv
strings
sync all: run go fmt 2024-02-28 20:35:05 +00:00
syscall syscall: call internal/runtime/syscall.Syscall6 in RawSyscall6 2024-03-04 17:26:21 +00:00
testdata
testing testing: fix typo in comment 2024-02-28 20:32:54 +00:00
text text/tabwriter: add recovered panic message to rethrow 2024-02-29 16:46:34 +00:00
time runtime: move per-P timers state into its own struct 2024-02-29 18:51:47 +00:00
unicode
unsafe
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.