1
0
mirror of https://github.com/golang/go synced 2024-11-07 10:46:18 -07:00
go/src
Cuong Manh Le d310b2a6b8 cmd/compile: set correct Defn for inlined vars
Currently, when copying definition node of an inlined var, we do not
update var Defn field to point to new copied node. That causes all
inlined vars point to the same Defn, and ir.StaticValue can not find
inlined var in the lhs of its definition.

clovar creates new ONAME node for local variables or params of closure
inside inlined function, by copying most of the old node fields. So the
new Node.Defn is not modified, its lhs still refer to old node
instead of new one.

To fix this, we need to do two things:

 - In subst.clovar, set a dummy Defn node for inlvar
 - During subst.node, when seeing OAS/OAS2 nodes, after substituting, we
   check if any node in lhs has the dummy Defn, then set it to the current
   OAS/OAS2 node.

Fixes #45606

Change-Id: Ib517b753a7643756dcd61d36deae60f1a0fc53c5
Reviewed-on: https://go-review.googlesource.com/c/go/+/312630
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-04-23 05:10:41 +00:00
..
archive archive/zip: fix imports block of biggestZipBytes generator 2021-04-18 17:40:12 +00:00
bufio
builtin
bytes
cmd cmd/compile: set correct Defn for inlined vars 2021-04-23 05:10:41 +00:00
compress
container
context
crypto all: remove redundant spaces before . and , 2021-04-20 00:49:17 +00:00
database/sql
debug
embed
encoding all: remove redundant spaces before . and , 2021-04-20 00:49:17 +00:00
errors
expvar
flag
fmt
go go/types: implement unsafe.Add and unsafe.Slice 2021-04-23 00:40:48 +00:00
hash all: remove redundant spaces before . and , 2021-04-20 00:49:17 +00:00
html
image
index/suffixarray
internal internal/bytealg: add power9 version of bytes index 2021-04-21 21:14:04 +00:00
io io/fs: document that caller can modify slice returned by ReadFile 2021-04-21 16:46:52 +00:00
log
math all: remove redundant spaces before . and , 2021-04-20 00:49:17 +00:00
mime
net net: don't check nil err twice in interfaceMessages on freebsd 2021-04-21 20:39:43 +00:00
os os: depend on Readlink only when necessary 2021-04-22 21:03:32 +00:00
path
plugin
reflect reflect: allow conversion from slice to array ptr 2021-04-21 00:54:39 +00:00
regexp
runtime runtime: skip work recheck for non-spinning Ms 2021-04-22 20:45:37 +00:00
sort
strconv
strings
sync
syscall syscall: use libc in Exec on openbsd/arm64 2021-04-21 15:57:05 +00:00
testdata
testing io/fs: document that caller can modify slice returned by ReadFile 2021-04-21 16:46:52 +00:00
text text/template/parse: add a mode to skip func-check on parsing 2021-04-19 16:49:40 +00:00
time
unicode
unsafe spec: add unsafe.Add and unsafe.Slice 2021-04-22 22:03:10 +00:00
vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.