1
0
mirror of https://github.com/golang/go synced 2024-11-18 22:44:48 -07:00
go/internal/lsp
Josh Baum cef9fc3bc8 internal/lsp/analysis/fillreturns: broaden type equality
The existing implementation contains strict equality rules for
comparing the return type in the function declaration against
the return types in the function body. This causes the code in the
return statement to be incorrectly overriden with its corresponding
zero value type by the fillreturns analyzer.

Fixes golang/go#38707

Change-Id: I07522aaf85f2a5f811a86cbc0951ae61035ff55e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/236617
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-06-05 18:10:38 +00:00
..
analysis internal/lsp/analysis/fillreturns: broaden type equality 2020-06-05 18:10:38 +00:00
browser
cache internal/lsp: support go mod vendor as a command 2020-06-04 18:33:45 +00:00
cmd internal/lsp: added a fill struct code action 2020-06-04 04:23:27 +00:00
debug internal/lsp: fix typo in code comment 2020-05-30 23:37:09 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: support go mod vendor as a command 2020-06-04 18:33:45 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/jsonrpc2: change StreamServer to operate on Conn instead of Stream 2020-06-03 17:07:01 +00:00
mod internal/lsp: support configurable codeLens 2020-05-08 18:47:35 +00:00
protocol internal/jsonrpc2: change jsonrpc2.Conn to be an interface 2020-06-03 17:06:45 +00:00
regtest internal/lsp: support go mod vendor as a command 2020-06-04 18:33:45 +00:00
snippet
source internal/lsp: support go mod vendor as a command 2020-06-04 18:33:45 +00:00
testdata internal/lsp: support code folding for composite literals 2020-06-04 17:49:48 +00:00
tests internal/lsp: added a fill struct code action 2020-06-04 04:23:27 +00:00
code_action.go internal/lsp: added a fill struct code action 2020-06-04 04:23:27 +00:00
command.go internal/lsp: support go mod vendor as a command 2020-06-04 18:33:45 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: support go mod vendor as a command 2020-06-04 18:33:45 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/lsp: change exit handling 2020-06-03 13:14:19 +00:00
generate.go internal/lsp: add run test code lens 2020-05-12 13:19:52 +00:00
highlight.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
lsp_test.go internal/lsp: added a fill struct code action 2020-06-04 04:23:27 +00:00
progress.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
references.go internal/lsp: refactor references/rename/implementations 2020-03-27 17:09:18 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
signature_help.go internal/event: extract keys to their own package 2020-04-23 18:13:43 +00:00
symbols.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
text_synchronization.go internal/lsp: lift up workdone instrumentation to didModifyFiles 2020-06-03 13:18:45 +00:00
workspace_symbol.go internal/lsp: add config option for SymbolMatch 2020-05-11 19:58:58 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00